Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
77bc368 to
d9faad5
Compare
src/rust/rust_kvs_tool/BUILD
Outdated
| "@score_baselibs_rust//src/log/mw_log", | ||
| "@score_crates//:pico_args", | ||
| "@score_crates//:tinyjson", | ||
| "@score_logging//src/rust/mw_logger", |
There was a problem hiding this comment.
can't rustc_flags comes from mw_logger ?
There was a problem hiding this comment.
Won't work without them.
| commit = "5a70133dd8bd632f5c07f200a5ee4bc9f507c23b", | ||
| remote = "https://github.com/eclipse-score/communication.git", | ||
| ) | ||
|
|
There was a problem hiding this comment.
we wait with PR until logging is fixed.
b065c66 to
ba914d3
Compare
3594ed5 to
18dc8b8
Compare
src/rust/rust_kvs/Cargo.toml
Outdated
| [dependencies] | ||
| adler32.workspace = true | ||
| tinyjson.workspace = true | ||
| mw_log.workspace = true |
There was a problem hiding this comment.
the build with cargo only works with stdlogger right?
There was a problem hiding this comment.
Yes, but to be clear - this is not due to some issues or limitations. stdout_logger is just the only implementation that exists and interoperates with Cargo.
rust_kvs does not specify backend, because it can work with any.
18dc8b8 to
c2eabd7
Compare
ac5219a to
d110ca3
Compare
BUILD
Outdated
| # "@score_platform//:needs_json", | ||
| # "@score_process//:needs_json", |
There was a problem hiding this comment.
this is why external needs are not found and docs do not build
- Use `stdout_logger` for Cargo builds. - Use `score_log_bridge` for Bazel builds. - Additional logs from Rust implementation. - Use proxy module for logging with correct context across the lib. - Fix tests. - Bump toolchain version.
d110ca3 to
d4b1afa
Compare
stdout_loggerbackend for Cargo builds.score_log_bridgebackend for Bazel builds.