Skip to content

Conversation

@atarekra
Copy link
Contributor

@atarekra atarekra commented Nov 9, 2025

This pull request introduces support for specifying the maximum size of the Key-Value Storage (KVS) at compile time, fulfilling the related requirement:

"The Key-Value-Storage shall support specification of its maximum size at compile time."

and resolves #161

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 93f925dd-c370-4ef5-b7c4-d9398258151e
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_bazel_platforms', the root module requires module version score_bazel_platforms@0.0.2, but got score_bazel_platforms@0.0.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_process', the root module requires module version score_process@1.3.2, but got score_process@1.4.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (87 packages loaded, 10 targets configured)

Analyzing: target //:license-check (148 packages loaded, 1240 targets configured)

Analyzing: target //:license-check (149 packages loaded, 6681 targets configured)

Analyzing: target //:license-check (153 packages loaded, 6814 targets configured)

Analyzing: target //:license-check (155 packages loaded, 6832 targets configured)

Analyzing: target //:license-check (155 packages loaded, 6832 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8842 targets configured)

INFO: Analyzed target //:license-check (160 packages loaded, 9092 targets configured).
[6 / 14] [Prepa] Creating source manifest for @@score_tooling+//dash/tool/formatters:dash_format_converter [for tool]
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 62 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[11 / 14] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[12 / 14] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 20.422s, Critical Path: 2.61s
INFO: 14 processes: 9 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

The created documentation from the pull request is available at: docu-html

@Ahmed-Elsaka-JC
Copy link
Contributor

I see the following points :
user will face issue while flush to memory , i would say it would be better to let use know erlier while using set API to return error in case current storage size in ram exceed configured size.

Copy link
Contributor

@PandaeDo PandaeDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please solve all the build errors?

@atarekra
Copy link
Contributor Author

atarekra commented Feb 2, 2026

Could you please solve all the build errors?
Solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add compile-time configuration for maximum Key-Value Storage (KVS) size

3 participants