rust: Update toolchain and dependencies#156
Draft
umaucher wants to merge 1 commit intoeclipse-score:mainfrom
Draft
rust: Update toolchain and dependencies#156umaucher wants to merge 1 commit intoeclipse-score:mainfrom
umaucher wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
- rules_rust 0.56.0 -> 0.67.0 - rust.toolchain edition 2021 -> 2024, version 1.85.0 -> 1.90.0 - rust_qnx8_toolchain 1.0.0 -> 1.2.0 Needs backward compatible fix for ref handling.
umaucher
force-pushed
the
um_rust_update
branch
from
a49302e to
b347b00
Compare
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
arkjedrz
suggested changes
Oct 30, 2025
| type Error = String; | ||
| fn try_from(value: &KvsValue) -> Result<Self, Self::Error> { | ||
| if let KvsValue::$variant(ref n) = value { | ||
| if let KvsValue::$variant(n) = value { |
Contributor
Author
There was a problem hiding this comment.
the old version silently allows redundant ref definitions where the new version explicitly rejects them
error: binding modifiers may only be written when the default binding mode is `move`
--> src/rust/rust_kvs/src/kvs_value.rs:93:43
|
93 | if let KvsValue::$variant(ref n) = value {
| ^^^^^ occurs within macro expansion
...
so the usage without ref would have been correct before already.
| versions = ["1.90.0"], | ||
| ) | ||
|
|
||
| # ToDo: Official release needed, documentaion on usage of rust toolchains missing |
Contributor
There was a problem hiding this comment.
Create an issue for that, this TODO doesn't seem relevant to persistency.
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Even with the ticket I still don't fully grasp the topic here: official release of what, and why is lack of documentation a TODO inside Persistency Bazel files?
arkjedrz
suggested changes
Oct 31, 2025
| versions = ["1.90.0"], | ||
| ) | ||
|
|
||
| # ToDo: Official release needed, documentaion on usage of rust toolchains missing |
Contributor
There was a problem hiding this comment.
Even with the ticket I still don't fully grasp the topic here: official release of what, and why is lack of documentation a TODO inside Persistency Bazel files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs backward compatible fix for ref handling.