set permission for kvs file#107
Open
Ahmed-Elsaka-JC wants to merge 1 commit intoeclipse-score:mainfrom
Open
Conversation
e60d583 to
3e2d2e2
Compare
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
- set permission for kvs file Fixes eclipse-score#99
3e2d2e2 to
b1426c9
Compare
|
The created documentation from the pull request is available at: docu-html |
Contributor
|
Looks good. @vinodreddy-g Will the api change for the builder ("storage_mode" method) be implemented in Rust? |
Contributor
|
@joshualicht @Ahmed-Elsaka-JC We can discuss in the coming meeting also . We could have the permissions for KVS , but we should not expose the os abstraction enum to the api level ,Since we might use a different file storage api or may be KVS is not file based for longterm. We could have a KVS enum for it and map it tot os abstraction internally. |
Contributor
|
Okay I put it on the meeting-board👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99