update kvs build to avoid reopen opened instance.

[Ahmed-Elsaka-JC]

• avoid openening same instance if from builder.

Closes #63

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: e088ea22-edc3-4924-a505-510134b91a41
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rules_boost+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-4mKwezZI/cRJtzanuKwfvj+C0wuCO5C+fxSvAIZIZG8="
DEBUG: Repository rules_boost+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
WARNING: For repository 'googletest', the root module requires module version googletest@1.15.0, but got googletest@1.17.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (75 packages loaded, 9 targets configured)

Analyzing: target //:license-check (132 packages loaded, 1037 targets configured)

Analyzing: target //:license-check (138 packages loaded, 2546 targets configured)

Analyzing: target //:license-check (141 packages loaded, 3771 targets configured)

Analyzing: target //:license-check (141 packages loaded, 4553 targets configured)

DEBUG: Rule 'toolchains_llvm++llvm+llvm_toolchain_llvm' indicated that a canonical reproducible form can be obtained by modifying arguments _action_listener = <unknown object com.google.devtools.build.lib.packages.Attribute$LabelListLateBoundDefault>, _config_dependencies = [], _configure = False, _environ = [], _original_name = "llvm_toolchain_llvm"
DEBUG: Repository toolchains_llvm++llvm+llvm_toolchain_llvm instantiated at:
  <builtin>: in <toplevel>
Repository rule llvm defined at:
  /home/runner/.bazel/external/toolchains_llvm+/toolchain/rules.bzl:27:23: in <toplevel>
Analyzing: target //:license-check (141 packages loaded, 4553 targets configured)

INFO: Analyzed target //:license-check (142 packages loaded, 6488 targets configured).
[7 / 14] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_dash_license_checker+/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 65 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 188.999s, Critical Path: 0.32s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 65 items.
[main] INFO Found 34 items.
[main] INFO Querying ClearlyDefined for license data for 31 items.
[main] ERROR Error response from ClearlyDefined 429

[github-actions]

The created documentation from the pull request is available at: docu-html

[joshualicht]

Looks good.

One question: Was the api change for the builder with the method "clear_cache" aligned with Rust-Devs? (Just to keep the APIs aligned as much as possible)

[Ahmed-Elsaka-JC]

Looks good.

One question: Was the api change for the builder with the method "clear_cache" aligned with Rust-Devs? (Just to keep the APIs aligned as much as possible)

• i can check align this point in comming meeting.
• but i see if we will cache we should allow the user to clear the cache.

[joshualicht]

• but i see if we will cache we should allow the user to clear the cache.

Sure, for me its only important that the usage of the method is aligned, so that we work on the same changes on Rust and C++

• i can check align this point in comming meeting.

Maybe @vinodreddy-g can help here so we dont need to wait until Thursday: Will this function be implemented in Rust?

[arkjedrz]

Please check if #91 isn't solving similar issue for Rust.

[FScholPer]

@Ahmed-Elsaka-JC any status update here?