-
Notifications
You must be signed in to change notification settings - Fork 10
Feature/logfile size control #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/logfile size control #44
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
|
This PR eclipse-score/baselibs#83 is related to this one |
| config.IsCircularFileLogging(), | ||
| config.IsOverwriteLogOnFull(), | ||
| config.GetMaxLogFileSizeBytes(), | ||
| config.GetNoOfLogFiles(), | ||
| config.IsTruncateOnRotation()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the benefit to pass these config parameters individually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicit interface and dependencies, decoupling and easier for unit testing
This pull request is related to new feature for managing log file sizes to prevent them from growing indefinitely and consuming excessive disk space. A log file size policy has been implemented to control the maximum size of log files and to handle log rotation.
References
eclipse-score/baselibs#34