Making the host ip device configurable#29
Open
MaciejKaszynski wants to merge 3 commits intoeclipse-score:mainfrom
Open
Making the host ip device configurable#29MaciejKaszynski wants to merge 3 commits intoeclipse-score:mainfrom
MaciejKaszynski wants to merge 3 commits intoeclipse-score:mainfrom
Conversation
draganbjedov
suggested changes
Jan 30, 2026
| target.teardown() | ||
| dlt = None | ||
| if target_config.data_router_config: | ||
| dlt = DltReceive( |
Contributor
There was a problem hiding this comment.
You are missing with. DltReceive is context manager. In other targets as well.
45b0c8b to
94d6916
Compare
draganbjedov
suggested changes
Feb 2, 2026
Comment on lines
48
to
63
| if target_config.data_router_config: | ||
| dlt = DltReceive( | ||
| target_ip=target_config.ip_address, | ||
| protocol=Protocol.UDP, | ||
| data_router_config=target_config.data_router_config, | ||
| binary_path=test_config.dlt_receive_path, | ||
| ) | ||
| dlt.start_process() | ||
|
|
||
| target = TargetQvp(test_config.ecu, test_config.os) | ||
| target.register_processors(qvp_process) | ||
| yield target | ||
| target.teardown() | ||
| finally: | ||
| if dlt: | ||
| dlt.kill_process() |
Contributor
There was a problem hiding this comment.
Suggested change
| if target_config.data_router_config: | |
| dlt = DltReceive( | |
| target_ip=target_config.ip_address, | |
| protocol=Protocol.UDP, | |
| data_router_config=target_config.data_router_config, | |
| binary_path=test_config.dlt_receive_path, | |
| ) | |
| dlt.start_process() | |
| target = TargetQvp(test_config.ecu, test_config.os) | |
| target.register_processors(qvp_process) | |
| yield target | |
| target.teardown() | |
| finally: | |
| if dlt: | |
| dlt.kill_process() | |
| if target_config.data_router_config: | |
| dlt = DltReceive( | |
| target_ip=target_config.ip_address, | |
| protocol=Protocol.UDP, | |
| data_router_config=target_config.data_router_config, | |
| binary_path=test_config.dlt_receive_path, | |
| ) | |
| with dlt if dlt else nullcontext(): | |
| target = TargetQvp(test_config.ecu, test_config.os) | |
| target.register_processors(qvp_process) | |
| yield target | |
| target.teardown() |
draganbjedov
reviewed
Feb 2, 2026
Contributor
draganbjedov
left a comment
There was a problem hiding this comment.
Please squash related commits and then I can approve.
e5f27a5 to
0af99d8
Compare
Author
Done |
draganbjedov
approved these changes
Feb 2, 2026
Contributor
|
@MaciejKaszynski Did you tested this by running ITF tests from |
Author
Locally I get a pass for qnx_qemu image. I used |
Contributor
|
You need to rebase. We have changed ITF structure #30 |
0af99d8 to
a10f5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
host_ip.host_diagnostic_ipoptional configuration field.data_router_configconfiguration field optional so that if nothing is configured no dlt is created.