-
Notifications
You must be signed in to change notification settings - Fork 7
Enable Bazel disk cache by default to speed up repeated builds #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MTomBosch
wants to merge
1
commit into
eclipse-score:main
Choose a base branch
from
MTomBosch:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that work with every github runner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this was meant for local usage. But indeed it might break workflows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FScholPer Not complaining just asking: How would this break the runner? If the runner uses the container then the container will be the runtime environment environment for the job and in the container I am quite sure the file path ~/.bazelrc is accessible. Or do you mean that the ~ cannot be resolved to the proper home folder location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the on_create_command to my knowledge is only executed in vscode when choosing the bazel feature to be used. The original/raw container does not even have the bazel stuff in it.
Or can the GHA runner also make use of this devcontainer "feature" functionality too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tools installed via devcontainer features are available. However at least with a simple docker run the startup scripts of these features are not executed:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the concern is that the settings might increase disk usage of bazel in runners. I tend to believe that at the moment bazels disk usage is unbounded and with this change I hope that with these settings the size of the bazel cache is limited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want the full devcontainer running you can do it like this:
devcontainer/.github/workflows/ci.yaml
Line 47 in c17061b
This should only make use of the image: https://github.com/eclipse-score/reference_integration/blob/a1e29b78844b6258eb6692aabbf349cc83d1f945/.github/workflows/build_and_test_ebclfsa.yml#L32-L33