Add flatbuffer support for COM configuration using flatbuffers#112
Add flatbuffer support for COM configuration using flatbuffers#112OliverHeilwagen wants to merge 4 commits intoeclipse-score:mainfrom
Conversation
|
Thank you for sharing this initial version of the flatbuffer support. |
|
See also general discussion here: #110 |
| { | ||
| if (ShouldUseFlatBuffer(path)) | ||
| { | ||
| // Warning is used to see usage in the default ipc bridge test setup |
There was a problem hiding this comment.
Change back to info before merging PR. Warning is currently only used to see effect in ipc bridge test.
Same applies to json log.
46dea4b to
75dcfcc
Compare
Signed-off-by: KaitoKid <thomas.mikhael@icloud.com>
| } | ||
|
|
||
| auto config = configuration::Parse(runtime_configuration.GetConfigurationPath().Native()); | ||
| auto config = configuration::Load(runtime_configuration.GetConfigurationPath().Native()); |
There was a problem hiding this comment.
@LittleHuba @castler @hoe-jo:
I guess we should first decide on the scope of this PR.
We could for example leave out this change to not yet allow for actual usage of flatbuffers by a user of COM and only introduce a initial set of changes e.g.:
- mw/com/impl/configuration
- ara_com_config.fbs
- flatbuffer_config_loader.h/cpp
- including the respective quality artifacts architecture, ..., tests
- bazel/tools
Please coordinate with @Thomas-Mikhael he will takeover the PR.
| """ | ||
|
|
||
| # Always use the COM FlatBuffer schema | ||
| schema = "//score/mw/com/impl/configuration:ara_com_config.fbs" |
There was a problem hiding this comment.
@Thomas-Mikhael: Please check all references in *.bzl, which is used outside of this module, we have to specify the full bazel path e.g.:
| schema = "//score/mw/com/impl/configuration:ara_com_config.fbs" | |
| schema = "@score_communication//score/mw/com/impl/configuration:ara_com_config.fbs" |
resolves #110
This initial version was focused on working ipc bridge test using flatbuffers, quality aspects are not yet covered.
It is recommended to break down the issue into smaller tasks and setup a merge strategy, PR is therefore draft only.
Pending decisions:
Changes (rough outline)
Open points: