central workflow for pr checks: issue #43#45
Conversation
nick-hildebrant-etas
changed the title
AlexanderLanin
requested review from
AlexanderLanin,
Copilot,
dcalavrezo-qorix,
nicu1989 and
nradakovic
There was a problem hiding this comment.
Pull Request Overview
This PR introduces GitHub Actions workflows to validate Bazel module naming conventions for the SCORE project. The implementation adds automated checks that run on pull requests targeting the main branch.
Key Changes:
- Adds a reusable workflow that validates MODULE.bazel files exist and contain properly formatted module names
- Integrates the validation workflow into the PR pipeline
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/score-pr-checks.yml |
Implements validation logic for MODULE.bazel existence and module name format compliance |
.github/workflows/on-pr.yml |
Triggers the SCORE PR checks workflow on pull requests to main branch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@dcalavrezo-qorix @nicu1989 @nradakovic please focus on the general idea of having |
dcalavrezo-qorix
left a comment
dcalavrezo-qorix
left a comment
There was a problem hiding this comment.
will work fine as long as the repos follow a pseudo-template.
I've seen repos with two Module files btw, so multiple modules within one repo
No MODULE? No Problem Co-authored-by: Alexander Lanin <alex@lanin.de> Signed-off-by: nick-hildebrant-etas <nick.hildebrant+etas@etas.com>
spaces around name with POSIX character classes Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: nick-hildebrant-etas <nick.hildebrant+etas@etas.com>
|
Valid argument @dcalavrezo-qorix. How is that handled currently when there is a repo with multiple modules and anyone starts releasing? |
|
Basically that is not supported. Do we have an example? |
This will only check the MODULE.bazel in the root of the repo. I can't think of a way to make this more generalized without an example. In the general case, this is how bazel works as well, so if you have multiple modules, you need to point to them from the main MODULE.bazel anyway right? I am happy to improve the action, but I can't think of a better way at the moment. |
There was a problem hiding this comment.
I think we should only use templates here
github-project-automation
bot
moved this from Draft
to Done
in INF - Infrastructure Community
4 participants
#43
Enable each component repo to use a single score-pr-checks workflow that references a reusable action in the cicd-workflows repo. This way, any update to the central workflow or action will automatically apply to all component repos, streamlining maintenance and rollout of new checks.