Skip to content

Fix improper compiler flag separation on QNX #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NEOatNHNG wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −5
Open

Fix improper compiler flag separation on QNX #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd2d0d
Add Bazel version file for consistent builds
NEOatNHNG Feb 9, 2026
c19e533
Fix improper compiler flag separation on QNX
NEOatNHNG Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .bazelversion
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8.4.2
Copy link
Member

@nradakovic nradakovic Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to have .bazelversion here? We don't have standalone targets in this module.

Copy link
Author

@NEOatNHNG NEOatNHNG Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a module file. I was so naive to try bazel test in order to execute any test cases that might be present, but that failed because it was using bazel 9.0.0 which chokes on some of the bazel code. Also if you have a bazel extension running in your IDE you have the same problem, it starts the bazel server in the wrong version and that fails. Also I think it is good behavior to just document the bazel version your code is supposed to work with.

6 changes: 1 addition & 5 deletions templates/qnx/cc_toolchain_config.bzl.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,11 +411,7 @@ def _impl(ctx):
iterate_over = "runtime_library_search_directories",
flag_groups = [
flag_group(
flags = [
"-Wl",
"-rpath",
"$EXEC_ORIGIN/%{runtime_library_search_directories}",
],
flags = ["-Wl,-rpath,$EXEC_ORIGIN/%{runtime_library_search_directories}"],
),
],
expand_if_available = "runtime_library_search_directories",
Expand Down