Skip to content

Conversation

@arunjose696
Copy link
Contributor

@arunjose696 arunjose696 commented Dec 17, 2025

This change replaces the old drawImage API calls in Table and Tree with the newer, simplified drawImage overload that requires fewer parameters. This is a minor refactoring and is a like-for-like replacement, with no functional changes only a reduction in the number of parameters passed.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

Test Results (win32)

   34 files  ±0     34 suites  ±0   4m 1s ⏱️ -40s
4 628 tests ±0  4 555 ✅ ±0  73 💤 ±0  0 ❌ ±0 
  167 runs  ±0    164 ✅ ±0   3 💤 ±0  0 ❌ ±0 

Results for commit 82dda26. ± Comparison against base commit 47e2587.

♻️ This comment has been updated with latest results.

@arunjose696 arunjose696 marked this pull request as ready for review December 23, 2025 10:02
This change replaces the old drawImage API call in Table and tree with
the newer, simplified drawImage overload that takes fewer parameters.
@akoch-yatta akoch-yatta force-pushed the arunjose696/464-TreeTable branch from a1dce0e to 82dda26 Compare December 23, 2025 16:12
Copy link
Contributor

@akoch-yatta akoch-yatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simplifying the code by using the new GC#drawImage API. Did not find any regression during testing

@akoch-yatta akoch-yatta merged commit 6adf02b into eclipse-platform:master Dec 29, 2025
17 checks passed
@akoch-yatta akoch-yatta deleted the arunjose696/464-TreeTable branch December 29, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt usages in SWT to new GC#drawImage API

2 participants