Skip to content

Ez5.4+#1

Open
Simounet wants to merge 7 commits intoeab-dev:masterfrom
Simounet:ez5.4
Open

Ez5.4+#1
Simounet wants to merge 7 commits intoeab-dev:masterfrom
Simounet:ez5.4

Conversation

@Simounet
Copy link

Hi there,
First of all, thanks for this useful bundle. I tried to used it with my eZ5.4 version and it didn't work out of the box because of deprecated call:

  • $query->criterion -> $query->query
  • SortClause\LocationPathString

There is no sort option in my code anymore but I don't think it is harmful.

I added two options. One to change the default root node fetched and the other one to handling specifics classes on multiple sitemaps generation.

I can totally understand that you don't want to merge this into your master branch if you are not using eZ5.4+ but you can consider to put this into a custom branch.

Have a nice day.

@Simounet
Copy link
Author

Hi again,

I removed the tutei_sitemap.base_url parameter to use the eZ default configuration.

@eab-andy
Copy link

These look good. But for the commit "Multiple sitemaps with specifics classes option" is "google_news_sitemap" a good example? I thought that Google News sitemap XML format was different from this format. Would you be able to change the name to just "news_sitemap" or "blog_sitemap"?
Thanks!

@eab-andy
Copy link

What would be great would be the possibility of not only changing content types but also the sitemap root subtree using a different route. Although I suppose in some cases just changing the content type has the same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants