Open
Conversation
Author
|
Hi again, I removed the |
|
These look good. But for the commit "Multiple sitemaps with specifics classes option" is "google_news_sitemap" a good example? I thought that Google News sitemap XML format was different from this format. Would you be able to change the name to just "news_sitemap" or "blog_sitemap"? |
|
What would be great would be the possibility of not only changing content types but also the sitemap root subtree using a different route. Although I suppose in some cases just changing the content type has the same result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
First of all, thanks for this useful bundle. I tried to used it with my eZ5.4 version and it didn't work out of the box because of deprecated call:
$query->criterion->$query->querySortClause\LocationPathStringThere is no sort option in my code anymore but I don't think it is harmful.
I added two options. One to change the default root node fetched and the other one to handling specifics classes on multiple sitemaps generation.
I can totally understand that you don't want to merge this into your master branch if you are not using eZ5.4+ but you can consider to put this into a custom branch.
Have a nice day.