Conversation
markspanbroek
force-pushed
the
marketplace-vault
branch
5 times, most recently
from
d65fee6 to
7791e85
Compare
Contributor
|
Using an image of commit 6e1a133 I've been running the release tests. Everything's coming up green. Tests are still running because these take forever. But enough of the tricky marketplace ones have already passed that I dare write this comment. Should trouble show up still, I'll be back! |
markspanbroek
force-pushed
the
marketplace-vault
branch
from
23e9372 to
3f8226f
Compare
benbierens
approved these changes
Jan 29, 2026
Contributor
benbierens
left a comment
benbierens
left a comment
There was a problem hiding this comment.
So many type changes :o
Quite happy with this though. 👍
Contributor
Author
|
I converted the nimble dependencies to submodules again. I was running into too many bugs and inconsistencies with the dependency resolution of nimble. |
Collateral that needs to be provided is now the same, regardless whether we're repairing or not. The repair reward is added as a bonus, not deducted as a discount.
fixes bugs with slotqueue and repostore, where expiry duration was misinterpreted as expiry timestamp
No longer test against the Marketplace contract directly, but only through the Market abstraction Reason: gas estimates are often incorrect, leading to test failures, and the same test scenarios are already handled by testMarkets
reason: nimble is very inconsistent with larger dependency graphs, and doesn't allow overriding of stint with our forked version
markspanbroek
force-pushed
the
marketplace-vault
branch
from
3f8226f to
20be396
Compare
dryajov
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version of logos-storage/logos-storage-nim#1196
Uses the latest version of the Marketplace contract that utilize the Vault contract.
This includes the following changes:
triggered more nimble bugs that we couldn't work around
Depends on durability-labs/archivist-contracts#26