Fix Notice: Undefined index: operator in addConditionGroup#38
Open
MurzNN wants to merge 1 commit intodrupal-graphql:8.x-1.xfrom
Open
Fix Notice: Undefined index: operator in addConditionGroup#38MurzNN wants to merge 1 commit intodrupal-graphql:8.x-1.xfrom
MurzNN wants to merge 1 commit intodrupal-graphql:8.x-1.xfrom
Conversation
When executing queries with ConditionGroup, that doesn't contain operator (that is not required), Drupal shows the notice: ``` Notice: Undefined index: operator in Drupal\graphql_search_api\Plugin\GraphQL\Fields\SearchAPISearch->addConditionGroup() (line 172 of web/modules/contrib/graphql_search_api/src/Plugin/GraphQL/Fields/SearchAPISearch.php). ``` Here is fix for this notice. Instead of `if` checking, I use the `??` construction, that must be available in PHP 7.0+ Also `value` may be not required too, so I add `NULL` replacement to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing queries with ConditionGroup, that doesn't contain operator (that is not required), Drupal shows the notice:
Here is fix for this notice. Instead of
ifchecking, I use the??construction, that must be available in PHP 7.0+Also
valuemay be not required too (for example, if operator = "IS_NULL"), so I addNULLreplacement to it.