Fix path traversal when generating output file name in GetDocumentInsider #64760
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the handling of invalid filename characters to include directory separators, ensuring consistent behavior across platforms. - Modified the output path generation to use the sanitized document name, preventing user-controlled paths from being interpreted incorrectly. - Added unit tests to validate the document name sanitization logic, covering various input scenarios.
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @@JRLK0. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Author
|
@dotnet-policy-service agree |
martincostello
added
area-commandlinetools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where GetDocumentInsider used the raw
documentNamevalue whenconstructing the output file path, allowing directory separators or traversal
sequences to influence the generated path.
Details
Although a sanitized version of
documentNamewas computed, it was not used whenbuilding the final output file name.
This change ensures the sanitized value is always used and treats directory
separators consistently across platforms.
Tests
Adds a regression test to ensure values such as
a/../bora\..\bcannot affectthe output path.
Notes
This issue was previously reported to MSRC (VULN-168240) and classified as a
non-serviciable security case.
Fixes #64758