Fix OData Controller Specification

[commonsensesoftware]

Fix OData Specification

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

The ODataControllerSpecification implements the IApiControllerSpecification, which is used to filter candidate API controllers for versioning. The specification logic is wholistically correct. The implementation also exposes part of the specification matching functions for additional, internal operations. The ODataApplicationModelProvider uses one of these overloads:

aspnet-api-versioning/src/AspNetCore/OData/src/Asp.Versioning.OData/OData/ODataApplicationModelProvider.cs

Line 96 in 3fc0719

else if ( !ODataControllerSpecification.IsSatisfiedBy( controller ) )

The wrong overload is selected, which results in a partial - rather than complete - matching process. This PR is a minor refactoring to ensure that the matching is internally performed correctly.

• Fixes ODataApplicationModelProvider ignores controllers with only specific methods marked with ODataAttributeRoutingAttribute #1118