Skip to content

Stabilize macOS agent setup#3928

Merged
paulmedynski merged 8 commits intomainfrom
dev/paul/macos
Feb 10, 2026
Merged

Stabilize macOS agent setup#3928
paulmedynski merged 8 commits intomainfrom
dev/paul/macos

Conversation

@paulmedynski
Copy link
Contributor

@paulmedynski paulmedynski commented Feb 2, 2026

Description

This PR makes a variety of small changes in an attempt to improve the stability of the macOS test runs:

  • Removed unused and obsolete pipeline template parameters throughout.
  • Increased test job timeout since flaky tests can add 30+ minutes to test runs 😞
  • Skipped one test that isfailing on macOS 50% of the time.
  • Many small changes due to Copilot suggestions.

Testing

The usual PR/CI runs will validate.

Copilot AI review requested due to automatic review settings February 2, 2026 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors SQL Server configuration in Azure DevOps pipelines by centralizing password management and adding diagnostic capabilities for macOS agent setup.

Changes:

  • Removed password parameter passing through template layers, replacing it with direct use of the $(Password) variable from the ADO Library "ADO Test Configuration Properties"
  • Removed temporary password generation/verification steps from the test job template
  • Added documentation comments explaining the Password variable source across all SQL Server configuration step templates
  • Enhanced macOS SQL Server setup with timestamp-based diagnostic output and improved error message clarity
  • Cleaned up trailing whitespace throughout the pipeline files

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eng/pipelines/common/templates/steps/configure-sql-server-win-step.yml Removed password parameter, replaced all parameter references with $(Password) variable, added documentation comment, cleaned up trailing whitespace
eng/pipelines/common/templates/steps/configure-sql-server-step.yml Removed password parameter definition and parameter passing to child templates
eng/pipelines/common/templates/steps/configure-sql-server-macos-step.yml Removed password parameter, replaced with $(Password) variable, added documentation, added PS4 timestamp prompt for diagnostics, improved error log message
eng/pipelines/common/templates/steps/configure-sql-server-linux-step.yml Removed password parameter, replaced with $(Password) variable, added documentation comment, cleaned up trailing whitespace
eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Removed password generation and verification steps that created a temporary GUID-based password

Copilot AI review requested due to automatic review settings February 2, 2026 15:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Feb 2, 2026
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.24%. Comparing base (104a401) to head (8bf46d0).
⚠️ Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (104a401) and HEAD (8bf46d0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (104a401) HEAD (8bf46d0)
addons 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3928      +/-   ##
==========================================
- Coverage   74.91%   67.24%   -7.67%     
==========================================
  Files         269      260       -9     
  Lines       43279    65704   +22425     
==========================================
+ Hits        32422    44183   +11761     
- Misses      10857    21521   +10664     
Flag Coverage Δ
addons ?
netcore 67.55% <ø> (-7.39%) ⬇️
netfx 66.12% <ø> (-8.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski changed the title Diagnose macOS agent setup problems Stabilize macOS agent setup Feb 3, 2026
Copilot AI review requested due to automatic review settings February 4, 2026 13:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

@paulmedynski paulmedynski marked this pull request as ready for review February 4, 2026 13:59
@paulmedynski paulmedynski requested a review from a team as a code owner February 4, 2026 13:59
Copilot AI review requested due to automatic review settings February 4, 2026 13:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

@priyankatiwari08 priyankatiwari08 self-assigned this Feb 9, 2026
@paulmedynski paulmedynski added this to the 7.0.0-preview4 milestone Feb 10, 2026
Copilot AI review requested due to automatic review settings February 10, 2026 12:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is no longer a work-in-progress, can you update the description to explain what the PR does? That'll be the first landing place if anyone wants to investigate the PR, so it'll be helpful to have it.

@paulmedynski paulmedynski merged commit 3ffbba7 into main Feb 10, 2026
293 checks passed
@paulmedynski paulmedynski deleted the dev/paul/macos branch February 10, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants