Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors SQL Server configuration in Azure DevOps pipelines by centralizing password management and adding diagnostic capabilities for macOS agent setup.
Changes:
- Removed password parameter passing through template layers, replacing it with direct use of the
$(Password)variable from the ADO Library "ADO Test Configuration Properties" - Removed temporary password generation/verification steps from the test job template
- Added documentation comments explaining the Password variable source across all SQL Server configuration step templates
- Enhanced macOS SQL Server setup with timestamp-based diagnostic output and improved error message clarity
- Cleaned up trailing whitespace throughout the pipeline files
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/common/templates/steps/configure-sql-server-win-step.yml | Removed password parameter, replaced all parameter references with $(Password) variable, added documentation comment, cleaned up trailing whitespace |
| eng/pipelines/common/templates/steps/configure-sql-server-step.yml | Removed password parameter definition and parameter passing to child templates |
| eng/pipelines/common/templates/steps/configure-sql-server-macos-step.yml | Removed password parameter, replaced with $(Password) variable, added documentation, added PS4 timestamp prompt for diagnostics, improved error log message |
| eng/pipelines/common/templates/steps/configure-sql-server-linux-step.yml | Removed password parameter, replaced with $(Password) variable, added documentation comment, cleaned up trailing whitespace |
| eng/pipelines/common/templates/jobs/ci-run-tests-job.yml | Removed password generation and verification steps that created a temporary GUID-based password |
eng/pipelines/common/templates/steps/configure-sql-server-macos-step.yml
Show resolved
Hide resolved
eng/pipelines/dotnet-sqlclient-ci-package-reference-pipeline.yml
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3928 +/- ##
==========================================
- Coverage 74.91% 67.24% -7.67%
==========================================
Files 269 260 -9
Lines 43279 65704 +22425
==========================================
+ Hits 32422 44183 +11761
- Misses 10857 21521 +10664
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
352833b to
58cb1bb
Compare
eng/pipelines/common/templates/steps/configure-sql-server-macos-step.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/common/templates/steps/configure-sql-server-macos-step.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/common/templates/steps/configure-sql-server-linux-step.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/common/templates/steps/configure-sql-server-win-step.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/common/templates/steps/publish-test-results-step.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/common/templates/steps/configure-sql-server-macos-step.yml
Show resolved
Hide resolved
…to arithmetically add extra time to macOS jobs.
…tests from timing out the jobs.
92113d4 to
8bf46d0
Compare
benrr101
left a comment
There was a problem hiding this comment.
Since this is no longer a work-in-progress, can you update the description to explain what the PR does? That'll be the first landing place if anyone wants to investigate the PR, so it'll be helpful to have it.
Description
This PR makes a variety of small changes in an attempt to improve the stability of the macOS test runs:
Testing
The usual PR/CI runs will validate.