Cleanup | Remove ResourceExposure and ResourceConsumption attributes#3836
Cleanup | Remove ResourceExposure and ResourceConsumption attributes#3836edwardneal wants to merge 6 commits intodotnet:mainfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
paulmedynski
left a comment
paulmedynski
left a comment
There was a problem hiding this comment.
One question about the csproj files.
src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/SniNativeWrapper.cs
Show resolved
Hide resolved
This is never set in Release configuration.
System; System.Runtime.Serialization; System.Security; System.Data; System.Xml; System.Runtime.Caching.
paulmedynski
left a comment
paulmedynski
left a comment
There was a problem hiding this comment.
Looks great! I love a good deletion PR.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
This pull request has been marked as stale due to inactivity for more than 30 days. If you would like to keep this pull request open, please provide an update or respond to any comments. Otherwise, it will be closed automatically in 7 days. |
github-actions
bot
added
the
Stale
|
This PR is not stale. |
github-actions
bot
removed
the
Stale
cheenamalhotra
added
the
Code Health 💊
|
This pull request has been marked as stale due to inactivity for more than 30 days. If you would like to keep this pull request open, please provide an update or respond to any comments. Otherwise, it will be closed automatically in 7 days. |
github-actions
bot
added
the
Stale
|
This PR is not stale. |
|
@edwardneal - Needs some conflicts resolved. |
|
Thanks @paulmedynski, I've just merged. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
github-actions
bot
removed
the
Stale
4 participants
Description
This cleanup builds on the initial split of System.Data.SqlClient from the rest of netfx. Various methods within the codebase were decorated with
[ResourceExposure]and[ResourceConsumption].These attributes were in turn decorated with
[Conditional("RESOURCE_ANNOTATION_WORK")], which means that they were never compiled into the finished binary unless that conditional compilation symbol was set. It's only set for debug builds, so we don't need to include the attributes. Doing so also removes some unnecessary netfx-specific conditional compilation.Issues
None.
Testing
Test cases continue to pass.