Add option to prevent halt when NFC tag not found on begin()#80
Open
smartin015 wants to merge 1 commit intodon:masterfrom
Open
Add option to prevent halt when NFC tag not found on begin()#80smartin015 wants to merge 1 commit intodon:masterfrom
smartin015 wants to merge 1 commit intodon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a project where an NFC reader may not always be attached. The current implementation of
begin()halts if the device isn't found on init - this is kind of a dealbreaker for my use case.So, my change adds an optional flag to
NfcAdapter::begin()that allows the user to bypass the halt behavior. The behavior without specifying this flag is unchanged, so there should be no worry about backwards compatibility.I've also made
begin()returntrueif the NFC board was initialized, andfalseotherwise to aid in potential sensing / retry logic on the user side.Thanks for maintaining this great repo :)