-
Notifications
You must be signed in to change notification settings - Fork 30
Add matrix testing for both hook installation methods #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: doitian <35768+doitian@users.noreply.github.com>
…rror handling Co-authored-by: doitian <35768+doitian@users.noreply.github.com>
Co-authored-by: doitian <35768+doitian@users.noreply.github.com>
Co-authored-by: doitian <35768+doitian@users.noreply.github.com>
Co-authored-by: doitian <35768+doitian@users.noreply.github.com>
Co-authored-by: doitian <35768+doitian@users.noreply.github.com>
…oks.py Co-authored-by: doitian <35768+doitian@users.noreply.github.com>
Co-authored-by: doitian <35768+doitian@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Set up matrix to install hooks using scripts
Add matrix testing for both hook installation methods
Jan 20, 2026
Owner
|
@copilot Do not test install-hooks.sh in Windows. |
Co-authored-by: doitian <35768+doitian@users.noreply.github.com>
Contributor
Author
Copilot stopped work on behalf of
doitian due to an error
January 20, 2026 16:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets up a matrix strategy in the GitHub Actions workflow to test hook installation using both
scripts/install-hooks.pyandscripts/install-hooks.sh.Changes
.github/workflows/test-hooks.ymlinstall-methodto the matrix with values['install-hooks.py', 'install-hooks.sh']INSTALL_HOOKS_METHODenvironment variable to the test stepcontents: read) for securityscripts/install-hooks.pyos.path.dirname(os.path.abspath(__file__))install-hooks.sh- can be run from any directorytest_hooks.py_install_hooks()to read theINSTALL_HOOKS_METHODenvironment variableinstall-hooks.pyorinstall-hooks.shinstall-hooks.pyas the default installation method_manual_install_hooks()fallback methodinstall-hooks.pyto set executable permissions on Unixinstall-hooks.shTesting
All tests pass with both installation methods on Linux:
install-hooks.py(default)install-hooks.shThe matrix ensures both scripts are tested on Ubuntu and macOS, while Windows only tests install-hooks.py.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.