Conversation
Some parts leaded to notice or warning. This is fixed.
|
Thanks @Nek-! |
|
Hey @Nek-, thank you for the PR! Some quick remarks before we can go ahead with merging this and releasing a 2.0.0 version that contains @bangpound's changes as well.
What do you think about the above? I'm happy to implement these changes quite quickly if you're also on board. |
The lockfileThe putenv() vs $_ENVHere is the output of my test: Notice that Symfony team use also New class dependency for default valueIMHO, overkill. But if you want to do it, I have nothing to stop you. |
This PR adds:
getEnvVarsFromConsulmethodBut this breaks the backward compatibility by changing the signature of a constructor.
Use this fork with the following configuration in your composer.json:
{ "require": { "dlapps/consul-php-envvar": "2.0.0-alpha1", }, "repositories": [ { "type": "vcs", "url": "https://github.com/Nek-/consul-php-envvar" } ] }