Skip to content

Bump go and deps#166

Merged
knuton merged 7 commits intodividat:mainfrom
yfyf:bump-deps
Feb 5, 2026
Merged

Bump go and deps#166
knuton merged 7 commits intodividat:mainfrom
yfyf:bump-deps

Conversation

@yfyf
Copy link
Contributor

@yfyf yfyf commented Feb 4, 2026

Bumping go to 1.23 to be able to update x/net and bumping logrus. This should resolve the remaining Dependabot issues, the others I reviewed and dismissed manually.

@yfyf yfyf requested a review from knuton February 4, 2026 09:16
@yfyf yfyf added the reviewable Ready for initial or iterative review. label Feb 4, 2026
@socket-security
Copy link

socket-security bot commented Feb 4, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​sirupsen/​logrus@​v1.8.1 ⏵ v1.8.398100 +16100100100

View full report

@yfyf
Copy link
Contributor Author

yfyf commented Feb 4, 2026

Welp, broke crossbuilds, one sec

yfyf added 3 commits February 4, 2026 11:27
Resulting binary not tested.

Cross-building with mingw_w64_pthreads broken in nixpkgs 24.11 for some
reason.
Cross-building on 24.11 seems to be broken
@yfyf
Copy link
Contributor Author

yfyf commented Feb 4, 2026

Fixed cross-building for Linux and Windows, but cannot get it to work for macOS (neither for ARM, nor for X86) with 24.11. So instead creating a hacky fix by using nixpkgs 25.05 for crossBuilds: 635976f

Alternatively we could use nix develop --override-input nixpkgs github:nixos/nixpkgs/25.05 in the Github Actions YAML for the macOS crossBuilds, but this is less transparent and harder to work with (now I can at least run make crossbuild_mac to verify the nix code/definitions are valid).

@knuton
Copy link
Member

knuton commented Feb 4, 2026

Fixed cross-building for Linux and Windows, but cannot get it to work for macOS (neither for ARM, nor for X86) with 24.11. So instead creating a hacky fix by using nixpkgs 25.05 for crossBuilds: 635976f

Could we use 25.05 everywhere?

@knuton knuton added details needed Further information requested to better evaluate changes and removed reviewable Ready for initial or iterative review. labels Feb 4, 2026
@yfyf
Copy link
Contributor Author

yfyf commented Feb 5, 2026

Could we use 25.05 everywhere?

I don't think it's a good idea, since PlayOS is at 24.11 and so our production build would be different from dev builds. Unless we change the release process to ship an actual binary.

Copy link
Member

@knuton knuton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just waiting for macOS build confirmation before merge.

@stoeffel
Copy link
Contributor

stoeffel commented Feb 5, 2026

 nix develop
bash-5.2$ make test
go: downloading github.com/sirupsen/logrus v1.8.3
go: downloading github.com/dividat/go-serial v1.6.4-usbmetadata
go: downloading golang.org/x/net v0.36.0
go: downloading golang.org/x/sys v0.30.0
Built bin/dividat-driver
npm install

added 1 package, removed 5 packages, changed 12 packages, and audited 116 packages in 1s

29 packages are looking for funding
  run `npm fund` for details

6 vulnerabilities (1 low, 1 moderate, 4 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm notice
npm notice New major version of npm available! 10.8.2 -> 11.9.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v11.9.0
npm notice To update run: npm install -g npm@11.9.0
npm notice
npm test

> driver-go@2.0.0-experimental test
> mocha --exit test/index.js



  General functionality
    1) Get message and version with HTTP get.
    ✔ Opening a second instance of the driver fails. (68ms)
    ✔ Get log entries from HTTP endpoint.

  CORS and PNA protection
    ✔ can make HTTP requests with no origin set
    ✔ can connect to WebSocket endpoints with no origin set
    ✔ can make HTTP requests with known origin set
    ✔ can connect to WebSocket endpoints with known origin set
    ✔ can not make HTTP requests with unknown origin set
    ✔ can not connect to WebSocket endpoints with unknown origin set

  Senso
    Basic functionality
      ✔ Can connect to a mock Senso. (1009ms)
      ✔ Can connect and disconnect to a mock Senso. (1009ms)
      ✔ Disconnect on multiple Connects. (1019ms)
      ✔ Can get connection status
      ✔ Data is forwarded from Senso data channel to WS (2245ms)
      ✔ Data is forwarded from WS to control channel (2278ms)
      ✔ Can discover mock Senso (983ms)

  RFID
    Basic functionality
      ✔ Can retrieve current reader list.
      ✔ Can connect to the RFID endpoint.

  Flex
    Flex functionality
      Generic features (PASSTHRU device/reader)
        ✔ Commands: Connect and GetStatus
        ✔ Commands: Discover (52ms)
        ✔ Multiple clients can Connect and GetStatus at the same time
        ✔ Broadcasts: Status on Connect and Disconnect  (2006ms)
        ✔ Can receive binary data verbatim with passthru (198ms)
      PASSTHRU-PretendFlex device
        ✔ present PASSTHRU-<foo> as <foo> device to client
      Flex v4 device
        ✔ can receive 8-bit synthetic data via WebSocket
      Flex v5 device
        ✔ can receive 12-bit synthetic data via WebSocket (55ms)
      Sensitronics device
        ✔ driver sends start command, chunks frames


  26 passing (22s)
  1 failing

  1) General functionality
bash-5.2$

@stoeffel
Copy link
Contributor

stoeffel commented Feb 5, 2026

bash-5.2$ make crossbuild_mac
nix develop '.#crossBuild.darwin.x86_64' --command bash -c "VERBOSE=1 ./build.sh -i ./src/dividat-driver/main.go -o bin/dividat-driver-darwin-amd64 -v 2.7.0-98-g635976f"
GOOS=darwin
GOARCH=amd64
GCO_ENABLED=1
CC=/usr/bin/clang
LD_FLAGS=-X github.com/dividat/driver/src/dividat-driver/server.version=2.7.0-98-g635976f
BUILD_TAGS=
# command-line-arguments
ld: warning: ignoring file /nix/store/cvhbqa01i5yy7xmmpqp1hbnvq7kpvgsx-clang-wrapper-19.1.7/resource-root/lib/darwin/libclang_rt.osx.a, building for macOS-x86_64 but attempting to link with file built for Mac Catalyst-arm64
ld: warning: ignoring file /nix/store/xdp9yf1r58jzfw1rh68qdhp0d923l07w-libresolv-83/lib/libresolv.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
Built bin/dividat-driver-darwin-amd64
nix develop '.#crossBuild.darwin.aarch64' --command bash -c "VERBOSE=1 ./build.sh -i ./src/dividat-driver/main.go -o bin/dividat-driver-darwin-arm64 -v 2.7.0-98-g635976f"
GOOS=darwin
GOARCH=arm64
GCO_ENABLED=1
CC=/usr/bin/clang
LD_FLAGS=-X github.com/dividat/driver/src/dividat-driver/server.version=2.7.0-98-g635976f
BUILD_TAGS=
Built bin/dividat-driver-darwin-arm64
bash-5.2$

@stoeffel
Copy link
Contributor

stoeffel commented Feb 5, 2026

rerunning make test passed sometimes

@knuton
Copy link
Member

knuton commented Feb 5, 2026

Flakiness on macOS traced to before this PR, will tackle independently.

@knuton knuton merged commit 0b99fb1 into dividat:main Feb 5, 2026
5 checks passed
@knuton knuton removed the details needed Further information requested to better evaluate changes label Feb 5, 2026
@yfyf yfyf deleted the bump-deps branch February 5, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants