Conversation
|
I would recommend changing the names of the installation scripts to be more descriptive instead of numbering to know how they differ, or at least add a documentation comment to the top of each one. |
|
|
||
| echo ">> Downloading model weights (4gb, may take awhile)" | ||
| # Download v1.4 model weights (so you can run `python txt2img.py` locally when testing) | ||
| wget "https://me.cmdr2.org/stable-diffusion-ui/sd-v1-4.ckpt" -O sd-v1-4.ckpt |
There was a problem hiding this comment.
wget is not available on macOS by default, use curl instead for portability
|
|
||
| echo ">> Creating environment diffusion bee" | ||
| # Create fresh python environment | ||
| conda create --name diffusionbee |
| # Download stable diffusion info | ||
| cd backends/stable_diffusion_torch | ||
|
|
||
| echo ">> Downloading stable diffusion code" | ||
| # Download the m1-compatible Stable Diffusion sampling infrastructure | ||
| git clone https://github.com/magnusviri/stable-diffusion.git | ||
| cd stable-diffusion | ||
| git checkout apple-mps-support | ||
| cd .. |
There was a problem hiding this comment.
Use pushd and popd instead of having to manually move around. (This script ends without returning the user to the root of the directory, by the by! With this, you can just popd at the end and leave the user at the beginning)
| # Download stable diffusion info | |
| cd backends/stable_diffusion_torch | |
| echo ">> Downloading stable diffusion code" | |
| # Download the m1-compatible Stable Diffusion sampling infrastructure | |
| git clone https://github.com/magnusviri/stable-diffusion.git | |
| cd stable-diffusion | |
| git checkout apple-mps-support | |
| cd .. | |
| # Download stable diffusion info | |
| pushd backends/stable_diffusion_torch | |
| echo ">> Downloading stable diffusion code" | |
| # Download the m1-compatible Stable Diffusion sampling infrastructure | |
| git clone https://github.com/magnusviri/stable-diffusion.git | |
| pushd stable-diffusion | |
| git checkout apple-mps-support | |
| popd |
|
|
||
| echo ">> Setting up electron app" | ||
| cd electron_app | ||
| npm i |
There was a problem hiding this comment.
npm does not ship with macOS. Consider checking for the existence of these commands upfront, and providing users with better context, with e.g.
if ! [ -x "$(command -v npm)" ]; then
echo 'Error: npm is not installed.' >&2
exit 1
fi3 participants
This PR adds 2 install scripts that automate the process of getting started with contributing to
DiffusionBeeThis is an amazing project, and I'm sure more people would be interested in contributing if getting started was a no-brainer