perf: Combinable histograms for angle module parallel execution #1937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Regarding this the updated module runs really slowly in parallel, so there's something bad happening somewhere. I have taken a bit of a diversion and decided to handle #1927 and then add one for your module so we can do a before/after comparison too. This is something we should commit do doing for every module we convert in this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've worked on parallelising the module using a similar approach to the previous multithreading work on #1882 (SiteRDF).
Running into a snag where
Angletests are failing only whenexecution_policyispar(but passing when running sequentially!).I'm guessing this is due to a part of the histogram binning process being non-thread safe, and I believe I have narrowed it down to the
Histogram3D, since the output from the 1D and 2d histograms looks correct ingdb. Surprising, as the histogram classes seem to all effectively be wrappers to a linear array, so I am still trying to figure out where this is going wrong in parallel 3D binning.