Skip to content

Hacky patch for new arch opt builds #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmick wants to merge 2 commits into
base: 0.81.4-discord
Choose a base branch
from
Open

Hacky patch for new arch opt builds #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edce85a
Conditionally register for profiling
pmick Jan 28, 2026
11cfc27
Adding a comment
pmick Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/hermes/HermesInstance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@ class HermesJSRuntime : public JSRuntime {
}

void unstable_initializeOnJsThread() override {
// On new arch, we're seeing a crash in release optimized builds here. Adding this as a stopgap measure to prevent
// the crash to allow us to more thoroughly test new arch while this is investigated.
#ifdef HERMES_ENABLE_PROFILING
runtime_->registerForProfiling();
#endif
}

private:
Expand Down
Loading