Fix compilation and remove nphysics mentions #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThierryBerger
commented
Sep 6, 2024
ThierryBerger
commented
- needed for new PR to pass their tests (Replace instant by web-time #53)
ThierryBerger
commented
Sep 6, 2024
Comment on lines
168
to
174
| /// Computes the AABB of this fluid. | ||
| #[cfg(feature = "nphysics")] | ||
| pub fn compute_aabb(&self, particle_radius: Real) -> ncollide::bounding_volume::AABB<Real> { | ||
| use ncollide::bounding_volume::{self, BoundingVolume}; | ||
| bounding_volume::local_point_cloud_aabb(&self.positions).loosened(particle_radius) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This should probably be kept but translated for parry ?
Member
There was a problem hiding this comment.
Agreed. The translation should look very similar. Parry’s point-cloud calculation function is in bounding_volume::details::local_point_cloud_aabb.
sebcrozet
approved these changes
Sep 6, 2024
Comment on lines
168
to
174
| /// Computes the AABB of this fluid. | ||
| #[cfg(feature = "nphysics")] | ||
| pub fn compute_aabb(&self, particle_radius: Real) -> ncollide::bounding_volume::AABB<Real> { | ||
| use ncollide::bounding_volume::{self, BoundingVolume}; | ||
| bounding_volume::local_point_cloud_aabb(&self.positions).loosened(particle_radius) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Agreed. The translation should look very similar. Parry’s point-cloud calculation function is in bounding_volume::details::local_point_cloud_aabb.
ThierryBerger
force-pushed
the
fix_unexpected_features
branch
from
3403bf7 to
14f5885
Compare
ThierryBerger
force-pushed
the
fix_unexpected_features
branch
from
c49ee7d to
d75d412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.