gpm: fix an issue during the 'Verify and install' firmware step#36
Open
gpm: fix an issue during the 'Verify and install' firmware step#36
Conversation
Member
diescalo
commented
Oct 15, 2024
diescalo
commented
- If the connection with the device is Bluetooth, the device could be reset without receiving an ACK when the install firmware API packet is issued on the write characterisitic. This causes an exception different than the expected in the 'Verify and install' firmware step, making the overall process to fail.
- Issue the 'Verify and install' packet in first instance and send the 'Verify' packet only if the previous one fails and the cause is not a timeout waiting for the answer.
- If the connection with the device is Bluetooth, the device could be reset without receiving an ACK when the install firmware API packet is issued on the write characterisitic. This causes an exception different than the expected in the 'Verify and install' firmware step, making the overall process to fail. - Issue the 'Verify and install' packet in first instance and send the 'Verify' packet only if the previous one fails and the cause is not a timeout waiting for the answer. Signed-off-by: Diego Escalona <diego.escalona@digi.com>
diescalo
requested review from
daescalona,
hgonzaleDigi,
rubenmoral and
tatianaleon
hgonzaleDigi
approved these changes
Oct 15, 2024
rubenmoral
approved these changes
Oct 15, 2024
tatianaleon
approved these changes
Oct 15, 2024
daescalona
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.