Add hardcoded pip dependency versions#9
Open
dhenschen wants to merge 1 commit intodigidotcom:masterfrom
Open
Conversation
Prior to this commit, The Travis CI and local unit test suites were failing. All of the unit test failures were related to version incompatibility issues with new pip dependencies. This commit adds explicit package versions of click and Twisted. The versions used are from the most passing Travis CI job at: https://travis-ci.org/digidotcom/python-wpa-supplicant/builds/248812490
posborne
approved these changes
Apr 19, 2019
|
Please can you merge this? The code is broken at the moment as the default packages pulled in are currently click 7.0 and Twisted 19.10.0... With click 6.7 and twisted 17.5.0, it works. Click 6.7 resolves the above error. Other errors occur later such as: which are resolved by installing Twisted 17.5.0. |
Contributor
|
@brandonmoser Can you help get this merged? ideally we would like a set of active maintainers on this project with the commit bit. Alternatively we can work out where to move the repo / setup a maintained fork outside of this org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this pull request, The Travis CI and local unit test suites were failing (see https://travis-ci.org/digidotcom/python-wpa-supplicant/builds/454696189). All of the unit test failures were related to version incompatibility issues with new pip dependencies.
This pull request adds explicit package versions of click and Twisted. The versions used are from the most passing Travis CI job at: https://travis-ci.org/digidotcom/python-wpa-supplicant/builds/248812490