fix: correct component imports, open apps in same window#1652
Open
amcgee wants to merge 2 commits intofeature-command-palettefrom
Open
fix: correct component imports, open apps in same window#1652amcgee wants to merge 2 commits intofeature-command-palettefrom
amcgee wants to merge 2 commits intofeature-command-palettefrom
Conversation
Contributor
|
🚀 Deployed on https://pr-1652--dhis2-ui.netlify.app |
Contributor
Noted. I imagine this would be to open whichever item is highlighted in a new tab. (apps, commands?, shortcuts?) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some imports were relative (
../../../../) when they should have imported from other component packages (@dhis2-ui/input, for example)I also updated the behavior of app links to open in the same window instead of a new one, maintaining the behavior of the previous app menu. We might want to support cmd/ctl+enter to open in a new tab.