feat: update the summary table to display a message#2002
Open
Chisomchima wants to merge 2 commits intomasterfrom
Open
feat: update the summary table to display a message#2002Chisomchima wants to merge 2 commits intomasterfrom
Chisomchima wants to merge 2 commits intomasterfrom
Conversation
Contributor
|
🚀 Deployed on https://pr-2002--dhis2-import-export.netlify.app |
Chisomchima
force-pushed
the
DHIS2-17164/dryrun-summary-update
branch
2 times, most recently
from
1c53038 to
d4a9ee7
Compare
Chisomchima
force-pushed
the
DHIS2-17164/dryrun-summary-update
branch
2 times, most recently
from
afc1b83 to
e0df447
Compare
Chisomchima
force-pushed
the
DHIS2-17164/dryrun-summary-update
branch
from
2941960 to
4434f17
Compare
kabaros
reviewed
Apr 2, 2024
Contributor
kabaros
left a comment
kabaros
left a comment
There was a problem hiding this comment.
one comment + please fix failing tests
| const Summary = ({ summary, importType }) => { | ||
| // gml import type object return | ||
| const Summary = ({ summary, importType, isDryRun }) => { | ||
| if (isDryRun) { |
Contributor
There was a problem hiding this comment.
this logic looks like it would apply to all import dry runs, but we want to only apply it to tracked entities and events .. right?
Chisomchima
force-pushed
the
DHIS2-17164/dryrun-summary-update
branch
2 times, most recently
from
21bca40 to
82f372c
Compare
…f a table when isdryrun is true feat: update the summary to display noticebox for pages based on import type
Chisomchima
force-pushed
the
DHIS2-17164/dryrun-summary-update
branch
from
82f372c to
09c2b19
Compare
kabaros
reviewed
Apr 3, 2024
| const Summary = ({ summary, importType }) => { | ||
| // gml import type object return | ||
| const Summary = ({ summary, importType, isDryRun }) => { | ||
| if (isDryRun && importType === 'TRACKER_IMPORT_JOB') { |
Contributor
There was a problem hiding this comment.
I would just put this in a variable to make the intention clearer
Suggested change
| if (isDryRun && importType === 'TRACKER_IMPORT_JOB') { | |
| const isTrackerDryRun = isDryRun && importType === 'TRACKER_IMPORT_JOB | |
| if (isTrackerDryRun) { |
and maybe add a comment for posterity:
// the new tracker endpoints don't return a full summary, so we're just showing the ignored/total
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17164
Description
In the case of a dry run, this commit updates the table summary (screenshots below), and instead show a Notification that says "{ignoredCount} entities will be ignored out of {totalCount} entities"
Known issues
Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots