chore: add analytics database keys (from source code)#1571
chore: add analytics database keys (from source code)#1571dayures wants to merge 1 commit intodhis2:masterfrom
Conversation
|
@jason-p-pickering could you review this? |
|
will defer to @luciano-fiandesio |
bobjolliffe
left a comment
There was a problem hiding this comment.
Great to see these keys coming in to the documentation. I would recommend commenting out the actual settings in this case. Sometimes people will take the reference conf file and modify it (I sometimes do that). In that case they might miss to comment these out. By default there should be no analytics.database settings. Unless you do indeed have another separate postgresql database for this
|
Thanks for the feedback @bobjolliffe . I am happy to contribute in the most useful way. BTW, there is a big note before the file content saying "You should not attempt to use this configuration file directly, rather use it as a reference for the available configuration options. Many of the properties are optional." How should be added the "analytics.database" parameters? Adding them commented out ? |
No description provided.