fix(pwa): file SWR filter & allow navigation 403s [LIBS-356] [LIBS-357]#762
fix(pwa): file SWR filter & allow navigation 403s [LIBS-356] [LIBS-357]#762KaiVandivier merged 2 commits intomasterfrom
Conversation
amcgee
left a comment
amcgee
left a comment
There was a problem hiding this comment.
I think this looks good, nice and simple! I'm approving, but let's discuss super quickly what the implications of changing this are, just so we make sure it's super low-risk for 2.39.0
|
Summary of in-person discussion: We'll go with this minimal fix instead of PR #757 (which includes some client-side changes) with the intention of keeping it simple for 2.39.0. This simpler version will address unauthorized users from viewing pwa apps while online, but there will still be some obscure situations where an unauthorized user can see a pwa app while offline. It will only work when deployed on production instances; apps deployed as standalone on netlify or elsewhere won't return the 403. The SWR changes will fix some issues that we saw by only handling images; the performance benefit that we want is really only on images anyway. Caching dhis2/app-runtime#1268 will also help avoid issues with the SWR strategy showing requests belonging to another user. |
## [10.1.2](v10.1.1...v10.1.2) (2022-10-24) ### Bug Fixes * **pwa:** file SWR filter & allow navigation 403s [LIBS-356] [LIBS-357] ([#762](#762)) ([bbfd3eb](bbfd3eb))
|
🎉 This PR is included in version 10.1.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
# [10.2.0-alpha.2](v10.2.0-alpha.1...v10.2.0-alpha.2) (2022-11-15) ### Bug Fixes * **deps:** bump app-runtime to 3.6.1 [LIBS-356] ([#763](#763)) ([190b9e7](190b9e7)) * **deps:** update app-runtime and ui packages ([#761](#761)) ([f6406c5](f6406c5)) * **offline-interface:** protect against SW errors ([ad3e476](ad3e476)) * **pwa:** file SWR filter & allow navigation 403s [LIBS-356] [LIBS-357] ([#762](#762)) ([bbfd3eb](bbfd3eb)) * **pwa-boundary:** catch errors ([ecd8b21](ecd8b21))
|
🎉 This PR is included in version 10.2.0-alpha.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 participants
Pared down version of #757
Addresses https://dhis2.atlassian.net/browse/TECH-1462 (partially)
Pairs well with dhis2/app-runtime#1268 🥂