Skip to content

Conversation

@cgundy
Copy link
Contributor

@cgundy cgundy commented Dec 22, 2025

This removes all the icos dependencies that are not needed for running system tests. These include:

  • fakeroot
  • grub-efi-amd64-bin
  • iputils-ping
  • lsb-release
  • lvm2

For the ones we keep I added comments for where and why they are needed.

It's possible that this could break other workflows, however, I will monitor it closely and think it's helpful information to have, so we can separate out where those dependencies are needed and install them directly in the workflows required to make the docker image less bloated.

@cgundy cgundy added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Dec 22, 2025
@github-actions github-actions bot added the chore label Dec 22, 2025
IDX GitHub Automation and others added 21 commits December 22, 2025 15:47
…01dd71594cb48276984f4737bc32d9

Image tag: 4b4dd94876db867377e0011d3afec2f74f9db70761e0858fbafab8b779000bf7
…13f3de64e0c5357ff16609d25dc93c

Image tag: 84e5af58830a3f43bbe6eb00920511deb226fb9e60464573888ca217f18eb73e
Added libvirt-dev for managing virtual machines.
…4327edb0bce06d2ff012d328a24295

Image tag: c2ad2b682172f6cd6dac7a2f114aa801bd150654fe4eebdddf5847c9e04a1631
Add dependencies for IC-OS binaries related to disk management and virtual machines.
…6215b4e319cde99c5722f7b33c640a

Image tag: b2fab3ea896e1ee3be209174ce45c8b7c9fd7d6d4ffe38681852e136fc5372dc
Add dosfstools package for managing encrypted disks.
…ceac330e52b41f199a844ea0e5f3bf

Image tag: 3d160cd4d101962859d63eae7194b75fca51a1c24fa1444d82d1924570c3e297
…558cdfc7d0afd46fb1c953d7416169

Image tag: 627dab1fe95c6c963673876c9d92533e0ccd68f5622cab1409a52367b9dde09b
Added comments to clarify the purpose of dosfstools and mtools.
…4dab9d4941929ce772fbb7f75732cb

Image tag: acf4f6d0e4767b55eee1b7a954a1100e4d2821aeb97b9085179aedff96dacc24
…85a0d652e0d7e65255344a1c3a2f8a

Image tag: b603a3899addfd159cdb20bd0a734523dbfc01298a5bab19bdc5420a54a258cb
…9bc73447938b1e4dab05ab9e13eebb

Image tag: 37bab6369974f6d85cc8d13d287f17c428903c8b54f4ce4c3aca8715dab239b5
…e925d0926566d8bd49e840b4d5bc64

Image tag: b7473d32cf656fcf605d1ed9d330a702e364f57f84138b6a36f9e7683b521008
…9ad4f3697d494ee8aa60b903d2cb7f

Image tag: 11d2a03bb0973bcfe8247166dd2b471c36f12eb2d2bade1a5c2de18ea1d28bf0
@github-actions
Copy link
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/20461095561

New container image: sha256:3cb2afea4afa0a9cbc946c767cce1d42c79ad4f3697d494ee8aa60b903d2cb7f
New container tag: 11d2a03bb0973bcfe8247166dd2b471c36f12eb2d2bade1a5c2de18ea1d28bf0

@dfinity dfinity deleted a comment from github-actions bot Dec 24, 2025
@dfinity dfinity deleted a comment from github-actions bot Dec 24, 2025
@dfinity dfinity deleted a comment from github-actions bot Dec 24, 2025
@dfinity dfinity deleted a comment from github-actions bot Dec 24, 2025
@dfinity dfinity deleted a comment from github-actions bot Dec 24, 2025
@dfinity dfinity deleted a comment from github-actions bot Dec 24, 2025
@dfinity dfinity deleted a comment from github-actions bot Dec 24, 2025
@dfinity dfinity deleted a comment from github-actions bot Dec 24, 2025
@dfinity dfinity deleted a comment from github-actions bot Dec 24, 2025
…2e5320760687dd65e9a323f1bdb062

Image tag: 7b8aac7023321f4a27877e4ac2603da221c8ac83116eaf085ffada890ccc034b
@github-actions
Copy link
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/20479770023

New container image: sha256:545a047c1e7258b010de83b74f6cf25b5f2e5320760687dd65e9a323f1bdb062
New container tag: 7b8aac7023321f4a27877e4ac2603da221c8ac83116eaf085ffada890ccc034b

…294058bddf215838b7f48c40abbf2f

Image tag: f90ae49b734a7727048d91917a4fec0fe45faf1ca64833964bb572811b705064
@github-actions
Copy link
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/20487076648

New container image: sha256:fab0aadaabca3ac87408e0f09ea73190fc294058bddf215838b7f48c40abbf2f
New container tag: f90ae49b734a7727048d91917a4fec0fe45faf1ca64833964bb572811b705064

@cgundy cgundy marked this pull request as ready for review January 6, 2026 12:49
@cgundy cgundy requested review from a team as code owners January 6, 2026 12:49
@cgundy cgundy added this pull request to the merge queue Jan 6, 2026
Merged via the queue into master with commit 72ccccc Jan 6, 2026
77 of 80 checks passed
@cgundy cgundy deleted the remove-all-icos-deps branch January 6, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 @defi-team @idx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants