feat: show redirection warning when KVM/SOL/IDER is enabled but redir… #3125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhavilosetty-intel
force-pushed
the
fix-ism-sol
branch
from
9a2150b to
f23db72
Compare
madhavilosetty-intel
force-pushed
the
fix-ism-sol
branch
from
15c4f8d to
cf2f447
Compare
There was a problem hiding this comment.
Pull request overview
Adds UI + logic to warn users when AMT dependent features (KVM/SOL/IDER) are enabled while redirection is disabled, and updates KVM/SOL flows to account for redirection.
Changes:
- Added new i18n strings for a redirection warning banner and enable action
- Updated KVM/SOL feature handling to require redirection before considering the feature “already enabled”
- Added/updated unit tests covering the new redirection-dependent behavior and the warning banner
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/assets/i18n/ar.json | Adds redirection warning + enable button translations |
| src/assets/i18n/de.json | Adds redirection warning + enable button translations |
| src/assets/i18n/en.json | Adds redirection warning + enable button translations |
| src/assets/i18n/es.json | Adds redirection warning + enable button translations |
| src/assets/i18n/fi.json | Adds redirection warning + enable button translations |
| src/assets/i18n/fr.json | Adds redirection warning + enable button translations |
| src/assets/i18n/he.json | Adds redirection warning + enable button translations |
| src/assets/i18n/it.json | Adds redirection warning + enable button translations |
| src/assets/i18n/ja.json | Adds redirection warning + enable button translations |
| src/assets/i18n/nl.json | Adds redirection warning + enable button translations |
| src/assets/i18n/ru.json | Adds redirection warning + enable button translations |
| src/assets/i18n/sv.json | Adds redirection warning + enable button translations |
| src/app/devices/sol/sol.component.ts | Converts amtFeatures to a signal and gates “SOL already enabled” on redirection |
| src/app/devices/sol/sol.component.spec.ts | Updates tests for signal-based amtFeatures and adds redirection-disabled scenarios |
| src/app/devices/kvm/kvm.component.ts | Gates “KVM already enabled” on redirection |
| src/app/devices/kvm/kvm.component.spec.ts | Adds tests for redirection-disabled scenarios |
| src/app/devices/general/general.component.ts | Adds helper getter to detect when redirection is required |
| src/app/devices/general/general.component.html | Adds warning banner + enable button when dependent features are on but redirection is off |
| src/app/devices/general/general.component.spec.ts | Adds tests asserting the warning banner behavior |
madhavilosetty-intel
force-pushed
the
fix-ism-sol
branch
from
e0bd499 to
10a30ff
Compare
…ection is off Display a warning with an Enable button at the top of the AMT Enabled Features section when a dependent feature (KVM, SOL, or IDER) is checked but the redirection listener is disabled. Warning is hidden when redirection is already enabled. Auto-enables redirection when any dependent feature is active.
madhavilosetty-intel
force-pushed
the
fix-ism-sol
branch
from
6c8399e to
6f6b2e2
Compare
rsdmike
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ection is off
Display a warning with an Enable button at the top of the AMT Enabled Features section when a dependent feature (KVM, SOL, or IDER) is checked but the redirection listener is disabled. Warning is hidden when redirection is already enabled. Auto-enables redirection when any dependent feature is active.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )