Skip to content

Conversation

@madhavilosetty-intel
Copy link
Contributor

@madhavilosetty-intel madhavilosetty-intel commented Jan 28, 2026

When device is in Client Control Mode (CCM), the Enforce Secure Boot checkbox is now checked and disabled, preventing users from modifying
this security setting. In Admin Control Mode (ACM), the checkbox
remains enabled and editable.

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

image

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

@madhavilosetty-intel madhavilosetty-intel changed the title fix(ocr): disable Enforce Secure Boot checkbox in CCM mode fix: disable Enforce Secure Boot checkbox in CCM mode Jan 28, 2026
@madhavilosetty-intel madhavilosetty-intel linked an issue Jan 28, 2026 that may be closed by this pull request
@madhavilosetty-intel madhavilosetty-intel force-pushed the disable-esb-ccm branch 5 times, most recently from 46f7fbd to 8783a43 Compare February 3, 2026 17:37
@madhavilosetty-intel madhavilosetty-intel marked this pull request as ready for review February 3, 2026 17:53
@madhavilosetty-intel madhavilosetty-intel self-assigned this Feb 3, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements conditional behavior for the "Enforce Secure Boot" checkbox based on device control mode. When a device is in Client Control Mode (CCM), the checkbox is automatically checked and disabled to enforce security requirements, while in Admin Control Mode (ACM), users retain the ability to modify this setting.

Changes:

  • Added logic to detect CCM mode by checking if ProvisioningMode === 4 from AMT version data
  • Modified both HTTP Boot and PBA Boot dialogs to disable the "Enforce Secure Boot" checkbox when in CCM mode
  • Updated form submission logic to use getRawValue() to capture disabled field values

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/assets/i18n/en.json Added translation key for CCM mode informational message
src/app/devices/device-toolbar/pba-boot-dialog/pba-boot-dialog.component.ts Added CCM mode detection and conditional disabling of enforceSecureBoot control
src/app/devices/device-toolbar/pba-boot-dialog/pba-boot-dialog.component.spec.ts Added comprehensive test coverage for CCM mode behavior
src/app/devices/device-toolbar/pba-boot-dialog/pba-boot-dialog.component.html Added conditional message display for CCM mode
src/app/devices/device-toolbar/http-boot-dialog/http-boot-dialog.component.ts Added CCM mode detection and conditional disabling of enforceSecureBoot control
src/app/devices/device-toolbar/http-boot-dialog/http-boot-dialog.component.spec.ts Added comprehensive test coverage for CCM mode behavior
src/app/devices/device-toolbar/http-boot-dialog/http-boot-dialog.component.html Added conditional message display for CCM mode
src/app/devices/device-toolbar/device-toolbar.component.ts Modified to fetch AMT version data and pass CCM status to dialog components
src/app/devices/device-toolbar/device-toolbar.component.spec.ts Updated tests to mock AMT version service and verify CCM mode propagation

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

@madhavilosetty-intel madhavilosetty-intel force-pushed the disable-esb-ccm branch 2 times, most recently from cbb98e1 to a71f831 Compare February 10, 2026 17:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

When device is in Client Control Mode (CCM),
the Enforce Secure Boot checkbox is now checked and disabled,
preventing users from modifying this security setting.
In Admin Control Mode (ACM), the checkbox remains enabled and editable.
@madhavilosetty-intel madhavilosetty-intel merged commit 17ad7ea into main Feb 11, 2026
8 checks passed
@madhavilosetty-intel madhavilosetty-intel deleted the disable-esb-ccm branch February 11, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor UI Improvements for OCR

2 participants