-
Notifications
You must be signed in to change notification settings - Fork 17
fix: disable Enforce Secure Boot checkbox in CCM mode #3101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d386f5e to
32ac50f
Compare
46f7fbd to
8783a43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements conditional behavior for the "Enforce Secure Boot" checkbox based on device control mode. When a device is in Client Control Mode (CCM), the checkbox is automatically checked and disabled to enforce security requirements, while in Admin Control Mode (ACM), users retain the ability to modify this setting.
Changes:
- Added logic to detect CCM mode by checking if
ProvisioningMode === 4from AMT version data - Modified both HTTP Boot and PBA Boot dialogs to disable the "Enforce Secure Boot" checkbox when in CCM mode
- Updated form submission logic to use
getRawValue()to capture disabled field values
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/assets/i18n/en.json | Added translation key for CCM mode informational message |
| src/app/devices/device-toolbar/pba-boot-dialog/pba-boot-dialog.component.ts | Added CCM mode detection and conditional disabling of enforceSecureBoot control |
| src/app/devices/device-toolbar/pba-boot-dialog/pba-boot-dialog.component.spec.ts | Added comprehensive test coverage for CCM mode behavior |
| src/app/devices/device-toolbar/pba-boot-dialog/pba-boot-dialog.component.html | Added conditional message display for CCM mode |
| src/app/devices/device-toolbar/http-boot-dialog/http-boot-dialog.component.ts | Added CCM mode detection and conditional disabling of enforceSecureBoot control |
| src/app/devices/device-toolbar/http-boot-dialog/http-boot-dialog.component.spec.ts | Added comprehensive test coverage for CCM mode behavior |
| src/app/devices/device-toolbar/http-boot-dialog/http-boot-dialog.component.html | Added conditional message display for CCM mode |
| src/app/devices/device-toolbar/device-toolbar.component.ts | Modified to fetch AMT version data and pass CCM status to dialog components |
| src/app/devices/device-toolbar/device-toolbar.component.spec.ts | Updated tests to mock AMT version service and verify CCM mode propagation |
src/app/devices/device-toolbar/pba-boot-dialog/pba-boot-dialog.component.html
Outdated
Show resolved
Hide resolved
648cf6c to
a7c1651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.
src/app/devices/device-toolbar/pba-boot-dialog/pba-boot-dialog.component.ts
Show resolved
Hide resolved
src/app/devices/device-toolbar/pba-boot-dialog/pba-boot-dialog.component.ts
Outdated
Show resolved
Hide resolved
src/app/devices/device-toolbar/http-boot-dialog/http-boot-dialog.component.ts
Show resolved
Hide resolved
src/app/devices/device-toolbar/http-boot-dialog/http-boot-dialog.component.ts
Outdated
Show resolved
Hide resolved
cbb98e1 to
a71f831
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
src/app/devices/device-toolbar/http-boot-dialog/http-boot-dialog.component.html
Outdated
Show resolved
Hide resolved
src/app/devices/device-toolbar/pba-boot-dialog/pba-boot-dialog.component.ts
Outdated
Show resolved
Hide resolved
When device is in Client Control Mode (CCM), the Enforce Secure Boot checkbox is now checked and disabled, preventing users from modifying this security setting. In Admin Control Mode (ACM), the checkbox remains enabled and editable.
a71f831 to
6ddce97
Compare
When device is in Client Control Mode (CCM), the Enforce Secure Boot checkbox is now checked and disabled, preventing users from modifying
this security setting. In Admin Control Mode (ACM), the checkbox
remains enabled and editable.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )