-
Notifications
You must be signed in to change notification settings - Fork 10
docs: small grammatical fixes #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
graikhel-intel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Documentation cleanups across the MkDocs site to improve wording accuracy and fix a few references (repo link + diagram asset path) in the Device Management Toolkit docs.
Changes:
- Fix product naming/wording in videos and announcements docs.
- Correct an RPS GitHub link in the UI Toolkit React tutorial.
- Update the RPC overview diagram reference to use the SVG in
assets/images/diagramsand apply minor punctuation/typo fixes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/videos.md | Updates toolkit former name in the overview video section. |
| docs/announcements.md | Minor grammar fix (“continuing to work”). |
| docs/Tutorials/uitoolkitReact.md | Fixes RPS repository link. |
| docs/Reference/RPC/overview.md | Points RPC overview figure to the SVG diagram path. |
| docs/GetStarted/Enterprise/setup.md | Fixes punctuation and removes stray character in setup steps. |
| docs/GetStarted/Enterprise/createProfileACM.md | Reformats ordered list numbering in ACM profile creation steps. |
| docs/GetStarted/Cloud/buildRPC.md | Fixes capitalization typo in a table entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 1. Select the **Profiles** tab from the menu on the left. | ||
|
|
||
| 2. Under the **Profiles** tab, click **Add New** in the top-right corner to create a profile. | ||
| 1. Under the **Profiles** tab, click **Add New** in the top-right corner to create a profile. | ||
|
|
||
| <figure class="figure-image"> | ||
| <img src="..\..\..\assets\images\screenshots\Console_NewProfile.png" alt="Figure 2: Create a new profile"> | ||
| <figcaption>Figure 2: Create a new profile</figcaption> | ||
| </figure> | ||
|
|
||
| 3. Specify a **Profile Name** of your choice. | ||
| 1. Specify a **Profile Name** of your choice. | ||
|
|
||
| 4. Under **Activation**, select **Admin Control Mode** from the dropdown menu. | ||
| 1. Under **Activation**, select **Admin Control Mode** from the dropdown menu. | ||
|
|
||
| 5. Enable desired redirection features for the profile under **AMT Features - Enable/Disable features**. | ||
| 1. Enable desired redirection features for the profile under **AMT Features - Enable/Disable features**. | ||
|
|
||
| 6. Choose level of **User Consent**. By default for ACM, **None** is selected. This will disable all User Consent for ACM. | ||
| 1. Choose level of **User Consent**. By default for ACM, **None** is selected. This will disable all User Consent for ACM. | ||
|
|
||
| 7. Provide or generate a strong **AMT Password**. AMT will verify this password when receiving a command from Console. This password is also required for device deactivation. | ||
| 1. Provide or generate a strong **AMT Password**. AMT will verify this password when receiving a command from Console. This password is also required for device deactivation. | ||
|
|
||
| 8. Provide or generate a strong **MEBX Password**. This password can be used to access Intel® Manageability Engine BIOS Extensions (Intel® MEBX) on the AMT device. | ||
| 1. Provide or generate a strong **MEBX Password**. This password can be used to access Intel® Manageability Engine BIOS Extensions (Intel® MEBX) on the AMT device. | ||
|
|
||
| 9. Choose DHCP or Static based on environment for the **Network Configuration**. | ||
| 1. Choose DHCP or Static based on environment for the **Network Configuration**. | ||
|
|
||
| 10. This express setup assumes the managed device (i.e. AMT device) is on a wired connection for quickest setup. To learn more about a Wireless Setup, see the [Wireless Activation Tutorial](../../Tutorials/createWiFiConfig.md). | ||
| 1. This express setup assumes the managed device (i.e. AMT device) is on a wired connection for quickest setup. To learn more about a Wireless Setup, see the [Wireless Activation Tutorial](../../Tutorials/createWiFiConfig.md). | ||
|
|
||
| 11. For quickest setup, select **Non TLS** under **Provisioned Connection Configuration**. | ||
| 1. For quickest setup, select **Non TLS** under **Provisioned Connection Configuration**. | ||
|
|
||
| 12. Optionally, add **Tags** to help in organizing and querying devices as your list of managed devices grow. | ||
| 1. Optionally, add **Tags** to help in organizing and querying devices as your list of managed devices grow. | ||
|
|
||
| 14. Click **Save.** | ||
| 1. Click **Save.** |
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ordered list was changed to use repeated 1. for every step. While Markdown will usually auto-renumber, the rest of this doc (e.g., the earlier "Create a Domain" steps) and the corresponding CCM guide use explicit sequential numbering, so this becomes inconsistent and harder to read in raw form and diffs. Recommend reverting to explicit 2., 3., 4... numbering for these steps to match the surrounding documentation style.
| <!-- <h3>What's New: May 2024 Release (v{{ repoVersion.oamtct }})</h3> --> | ||
| <!-- <h3></h3> --> | ||
| <h3>Overview of Device Management Toolkit (formerly known as Device Management Toolkit)</h3><h3></h3><h3></h3> | ||
| <h3>Overview of Device Management Toolkit (formerly known as Open AMT Cloud Toolkit)</h3><h3></h3><h3></h3> |
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This heading line includes multiple empty <h3></h3> elements. Empty heading tags can confuse screen readers and negatively impact document structure/SEO. If these are only used for layout spacing, consider removing them and using CSS margin/padding (or non-heading elements) instead.
|
|
||
| !!! important | ||
| Using the default credentials is for TESTING ONLY. Not setting these values to your own values will result in an insecure deployment. For production deployments we recommended using an OAUTH provider (Auth0, Azure Entra AD, etc..) and configuring Console to use that instead. We may remove the default values in the future. ` | ||
| Using the default credentials is for TESTING ONLY. Not setting these values to your own values will result in an insecure deployment. For production deployments we recommended using an OAUTH provider (Auth0, Azure Entra AD, etc..) and configuring Console to use that instead. We may remove the default values in the future. |
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph still has a couple of grammatical/terminology issues: "we recommended" should be "we recommend", and "OAUTH" is typically spelled "OAuth". Also consider replacing "etc.." with "etc." for correct punctuation.
| Using the default credentials is for TESTING ONLY. Not setting these values to your own values will result in an insecure deployment. For production deployments we recommended using an OAUTH provider (Auth0, Azure Entra AD, etc..) and configuring Console to use that instead. We may remove the default values in the future. | |
| Using the default credentials is for TESTING ONLY. Not setting these values to your own values will result in an insecure deployment. For production deployments we recommend using an OAuth provider (Auth0, Azure Entra AD, etc.) and configuring Console to use that instead. We may remove the default values in the future. |
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?