Skip to content

Conversation

@rsdmike
Copy link
Member

@rsdmike rsdmike commented Feb 11, 2026

also ensure JWT signatures matches expected

Copilot AI review requested due to automatic review settings February 11, 2026 22:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses two critical authentication issues: fixing a missing return statement that allowed requests to proceed after authentication failures, and adding JWT signature validation to prevent algorithm confusion attacks.

Changes:

  • Added JWT signing method validation to ensure tokens use HMAC before parsing
  • Fixed missing return statement in OIDC verification error path that could allow unauthorized requests to proceed
  • Ensured consistent and secure JWT parsing across both HTTP API and WebSocket authentication flows

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
internal/controller/httpapi/v1/login.go Fixed missing return after OIDC auth failure and added HMAC signing method validation to JWT parsing
internal/controller/ws/v1/redirect.go Added HMAC signing method validation to JWT parsing in websocket authentication

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.69%. Comparing base (e16afa8) to head (203023a).

Files with missing lines Patch % Lines
internal/controller/httpapi/v1/login.go 0.00% 4 Missing ⚠️
internal/controller/ws/v1/redirect.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   39.70%   39.69%   -0.02%     
==========================================
  Files         112      112              
  Lines       10673    10676       +3     
==========================================
  Hits         4238     4238              
- Misses       6052     6055       +3     
  Partials      383      383              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

also ensure JWT signatures matches expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant