-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: use one logger throughout application #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
and should use configured log level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Refactors application startup to use a single shared pkg/logger instance by passing it through main → app.Run and into dependent components (e.g., HTTP server, OpenAPI generation).
Changes:
- Change
internal/app.Runto accept alogger.Interfacerather than creating its own logger. - Thread the logger through
cmd/app/main.go(including OpenAPI generation path) and update related tests/mocks. - Adjust HTTP server TLS test to provide a logger via the
httpserver.Logger(...)option.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/httpserver/server_tls_test.go | Passes an explicit logger option when exercising self-signed TLS path. |
| pkg/httpserver/server.go | Removes default field initialization from New() (notably the default logger). |
| internal/app/app_test.go | Updates test to call app.Run with an explicit logger instance. |
| internal/app/app.go | Updates Run signature to accept a logger and uses it throughout setup. |
| cmd/app/main_test.go | Updates mocks/signatures for runAppFunc and OpenAPI generation calls. |
| cmd/app/main.go | Creates one logger in main, passes it into app run and OpenAPI generation logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #802 +/- ##
==========================================
- Coverage 39.70% 39.70% -0.01%
==========================================
Files 112 112
Lines 10673 10670 -3
==========================================
- Hits 4238 4236 -2
+ Misses 6052 6051 -1
Partials 383 383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.