Skip to content

Conversation

@rsdmike
Copy link
Member

@rsdmike rsdmike commented Feb 11, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 11, 2026 20:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors application startup to use a single shared pkg/logger instance by passing it through mainapp.Run and into dependent components (e.g., HTTP server, OpenAPI generation).

Changes:

  • Change internal/app.Run to accept a logger.Interface rather than creating its own logger.
  • Thread the logger through cmd/app/main.go (including OpenAPI generation path) and update related tests/mocks.
  • Adjust HTTP server TLS test to provide a logger via the httpserver.Logger(...) option.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/httpserver/server_tls_test.go Passes an explicit logger option when exercising self-signed TLS path.
pkg/httpserver/server.go Removes default field initialization from New() (notably the default logger).
internal/app/app_test.go Updates test to call app.Run with an explicit logger instance.
internal/app/app.go Updates Run signature to accept a logger and uses it throughout setup.
cmd/app/main_test.go Updates mocks/signatures for runAppFunc and OpenAPI generation calls.
cmd/app/main.go Creates one logger in main, passes it into app run and OpenAPI generation logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.70%. Comparing base (e16afa8) to head (056cf83).

Files with missing lines Patch % Lines
cmd/app/main.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   39.70%   39.70%   -0.01%     
==========================================
  Files         112      112              
  Lines       10673    10670       -3     
==========================================
- Hits         4238     4236       -2     
+ Misses       6052     6051       -1     
  Partials      383      383              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant