fix: Update the validator criteria to allow wifi config is empty when DHCP is false #799
+268
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choonkeat1986
force-pushed
the
jira796
branch
from
a578658 to
1d73328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue
When create a profile with a network configuration for wired connection as static. There will be error promp when try to save the profile. The error promp as such "Invalid input: Key: 'Profile.WiFiConfigs' Error:Field validation for 'WiFiConfigs' failed on the 'excluded_if' tag"
What are you changing?
Update the profile validator to allow the wificonfig is empty when DHCP is false.
Tested: