Add support for generic matrix multiplication#25
Open
evanmcclure wants to merge 9 commits intodevfacet:mainfrom
Open
Add support for generic matrix multiplication#25evanmcclure wants to merge 9 commits intodevfacet:mainfrom
evanmcclure wants to merge 9 commits intodevfacet:mainfrom
Conversation
devfacet
requested changes
Apr 16, 2024
include/nn_dot_product_matrix.h
Outdated
| // | ||
| // The dimensions of the input matrices and the resultant matrix are | ||
| // implicitly the same. | ||
| void nn_dot_product_matrix(float result[MATRIX_MAX_ROWS][MATRIX_MAX_COLS], const float a[MATRIX_MAX_ROWS][MATRIX_MAX_COLS], const float b[MATRIX_MAX_ROWS][MATRIX_MAX_COLS]); |
devfacet
reviewed
Apr 16, 2024
src/nn_dot_product matrix.c
Outdated
Comment on lines
18
to
20
| for (int i = 0; i < NN_MATRIX_MAX_ROWS; i++) { | ||
| for (int j = 0; j < NN_MATRIX_MAX_COLS; j++) { | ||
| for (int k = 0; k < NN_MATRIX_MAX_ROWS; k++) { |
Owner
There was a problem hiding this comment.
We should use the size arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.