Fix problem when using typewatch with JSF and AJAX#38
Open
rlanhellas wants to merge 1 commit intodennyferra:masterfrom
Open
Fix problem when using typewatch with JSF and AJAX#38rlanhellas wants to merge 1 commit intodennyferra:masterfrom
rlanhellas wants to merge 1 commit intodennyferra:masterfrom
Conversation
…everytime (using jsf.ajax.addOnEvent) and it cause problem in typewatch plugin, because events (keydown, paste,cut and input) are called multiple times. So, if this event hit a database, the database is called multiple times causing a lot of problems (poor performance application).
To solve it, i added a name for each event (keydown.typewatch, paste.typewatch ...), and you can unbind just this event to restart typewatch, like this code:
´´´´
$(document).ready(function () {
jsf.ajax.addOnEvent(restartTypewatch);
});
function restartTypewatch(){
//unbind all events to avoid multiple calls
$('#my-input-text').unbind('keydown.typewatch paste.typewatch cut.typewatch input.typewatch');
//start typeWatch again
$('#my-input-text').typeWatch(options);
}
´´´´
You can't unbind all "keydown" events because it will cause problems in another jquery-plugins, like this:
´´´´
//unbind all keydown in this component can cause problem in others plugins, better unbind just typewatch
$('#my-input-text').unbind('keydown');
´´´´
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In JSF, when AJAX is called, the jquery-plugins need to be restarted everytime (using jsf.ajax.addOnEvent) and it cause problem in typewatch plugin, because events (keydown, paste,cut and input) are called multiple times. So, if this event hit a database, the database is called multiple times causing a lot of problems (poor performance application).
To solve it, i added a name for each event (keydown.typewatch, paste.typewatch ...), and you can unbind just this event to restart typewatch, like this code:
You can't unbind all "keydown" events because it will cause problems in another jquery-plugins, like this: