Skip to content

ci: check that API references do not cause Docusaurus build failures#437

Merged
anakin87 merged 8 commits intomainfrom
check-api-ref
Feb 13, 2026
Merged

ci: check that API references do not cause Docusaurus build failures#437
anakin87 merged 8 commits intomainfrom
check-api-ref

Conversation

@anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 13, 2026

Related Issues

Proposed Changes:

  • add a "Check API reference changes" workflow: if python files or pydoc configs are changed
    • generates Markdown API references
    • runs docusaurus-mdx-checker, as suggested in Docusaurus docs: this does not build the website but just checks generated Markdown files.
      • if it fails, the informative build error is available on CI logs

How did you test it?

Temporarily added some changes:

Notes for the reviewer

This is simpler than the approach used in deepset-ai/haystack-core-integrations#2829: we do not check docstrings checksums, etc. This means whenever python files or pydoc configs are changed, we generate all API references.

Since this repo generally has a small number of components and the whole workflow is fast and cheap (runs on Ubuntu slim), this simpler approach seems to be good enough.

Checklist

@coveralls
Copy link

coveralls commented Feb 13, 2026

Pull Request Test Coverage Report for Build 21980075337

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 57.682%

Files with Coverage Reduction New Missed Lines %
components/generators/chat/openai.py 12 46.67%
Totals Coverage Status
Change from base Build 21969631664: 0.0%
Covered Lines: 672
Relevant Lines: 1165

💛 - Coveralls

@anakin87 anakin87 changed the title Check api ref ci: check that API references do not cause Docusaurus build failures Feb 13, 2026
@anakin87 anakin87 marked this pull request as ready for review February 13, 2026 08:45
@anakin87 anakin87 requested a review from a team as a code owner February 13, 2026 08:45
@anakin87 anakin87 requested review from davidsbatista and julian-risch and removed request for a team and davidsbatista February 13, 2026 08:45
@anakin87 anakin87 self-assigned this Feb 13, 2026
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just wondering if we could use a more recent Python version. However, I understand tests use 3.10 too.

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: "3.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use a more recent version here? For example 3.13?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In tests, it makes sense because it's the lower supported version.
Here not particularly -> I'll switch to 3.13

@anakin87 anakin87 merged commit 86c4f82 into main Feb 13, 2026
@anakin87 anakin87 deleted the check-api-ref branch February 13, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants