-
Notifications
You must be signed in to change notification settings - Fork 210
test: replacing each DocumentStore specific tests and used the generalised ones from haystack.testing.document_store
#2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidsbatista
wants to merge
52
commits into
main
Choose a base branch
from
chore/removing-duplicated-standardised-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when needed due to new method from ExtendedTests
anakin87
reviewed
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
DeleteDocumentsTest,UpdateByFilterTest, etc.) instead of custom duplicated tests across integrations.Total tests removed: 49. and 7 overrides tests added in Azure AI Search
delete_all_documents()so it doesn’t calldelete(ids=[])on an empty collection (avoids Chroma error when there are no docs)._eq/_neinfilters.py(e.g.true/falsein OData).update_by_filter_and_waitupdated to acceptmeta(andfields/kwargs) and pass the correct updates intoupdate_by_filter.How did you test it?
pytest integrations/<name>/tests/test_document_store.py).Notes for the reviewer
delete_all_documents,delete_by_filterandupdate_by_filtergeneric tests tohaystack.testing.document_storehaystack#10477 is merged inhaystackpyproject.tomlis using this branch test: adddelete_all_documents,delete_by_filterandupdate_by_filtergeneric tests tohaystack.testing.document_storehaystack#10477 - before this PR is approved those need to be updated to point to the latest haystack releaseChecklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.