Skip to content

Conversation

@davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Feb 4, 2026

Related Issues

Proposed Changes:

  • Use Haystack’s shared document store test mixins (DeleteDocumentsTest, UpdateByFilterTest, etc.) instead of custom duplicated tests across integrations.
Document store # duplicated tests removed
Astra 3
Azure AI Search 6
Chroma 4
Elasticsearch 3
MongoDB Atlas 4
OpenSearch 3
pgvector 8
Pinecone 7
Qdrant 8
Weaviate 3

Total tests removed: 49. and 7 overrides tests added in Azure AI Search

  • Bug fixes
    • Chroma: Guard delete_all_documents() so it doesn’t call delete(ids=[]) on an empty collection (avoids Chroma error when there are no docs).
    • Azure AI Search: Handle booleans in filter helpers _eq / _ne in filters.py (e.g. true/false in OData).
    • Azure AI Search: Conftest update_by_filter_and_wait updated to accept meta (and fields/kwargs) and pass the correct updates into update_by_filter.

How did you test it?

  • Run each integration’s document store tests (e.g. pytest integrations/<name>/tests/test_document_store.py).
  • Confirm no custom delete/update-by-filter tests remain except where overrides are required (e.g. parametrized metadata or backend-specific options).

Notes for the reviewer

Checklist

@davidsbatista davidsbatista marked this pull request as ready for review February 4, 2026 19:01
@davidsbatista davidsbatista requested a review from a team as a code owner February 4, 2026 19:01
@davidsbatista davidsbatista requested review from anakin87, bogdankostic and sjrl and removed request for a team and bogdankostic February 4, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid duplicating test code in DocumentStore integrations

2 participants