fix(google_ai): close aiohttp session to prevent ResourceWarning#2629
Open
raymondWai wants to merge 3 commits intodeepset-ai:mainfrom
Open
fix(google_ai): close aiohttp session to prevent ResourceWarning#2629raymondWai wants to merge 3 commits intodeepset-ai:mainfrom
raymondWai wants to merge 3 commits intodeepset-ai:mainfrom
Conversation
vblagoje
requested changes
Dec 29, 2025
Member
There was a problem hiding this comment.
Thanks for the contrib but I don't think this is the right approach. The fix should close the session when the component is destroyed, not after each run_async call. The _client is stored as self._client (instance variable) and not created fresh each time.
Author
|
Just moved the close method call to destructor and exit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
When I try to use GoogleGenAIChatGenerator in a AsyncPipeline, It always show Unclosed client session error.
What I do to fix it is adding
self._client.aio.aclose()to the finally clause to run_async functionHow did you test it?
Run
pytest integrations/google_genai/tests/Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.