Skip to content

[Deepin-Kernel-SIG] [linux 6.18.y] [Deepin] scsi: leapraid: correct LEAPRAID_REPLY_SIZE macro#1472

Open
opsiff wants to merge 1 commit intodeepin-community:linux-6.18.yfrom
opsiff:linux-6.18.y-leapraid-typo
Open

[Deepin-Kernel-SIG] [linux 6.18.y] [Deepin] scsi: leapraid: correct LEAPRAID_REPLY_SIZE macro#1472
opsiff wants to merge 1 commit intodeepin-community:linux-6.18.yfrom
opsiff:linux-6.18.y-leapraid-typo

Conversation

@opsiff
Copy link
Member

@opsiff opsiff commented Feb 3, 2026

#1470

deepin inclusion
category: other

fix the typo.

Fixes: 08c6c3c ("scsi: leapraid: supports LeapRaid controller")

Summary by Sourcery

Bug Fixes:

  • Fix incorrect LEAPRAID reply size macro name used in reply buffer allocation, initialization, and bounds checking in the LeapRaid driver.

deepin inclusion
category: other

fix the typo.

Fixes: 08c6c3c ("scsi: leapraid: supports LeapRaid controller")
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 3, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Corrects a misspelled LEAPRAID reply buffer size macro and updates all its usages to the proper LEAPRAID_REPLY_SIZE name in the LeapRaid SCSI driver, ensuring consistent calculations for reply buffer sizing, DMA allocation, and address handling.

File-Level Changes

Change Details Files
Rename the LEAPRAID reply buffer size macro to LEAPRAID_REPLY_SIZE and update all references to use the corrected name.
  • Change the macro definition from LEAPRAID_REPLY_SIEZ to LEAPRAID_REPLY_SIZE while preserving its value (128).
  • Update reply buffer size usage in reply address range checks and iteration steps for reply message addresses.
  • Update DMA allocation and free calls to use the corrected reply size macro for coherent memory used by reply messages.
  • Adjust memset and copy_to_user size calculations for control command replies to rely on the corrected reply size macro.
  • Update the leapraid_default_reply struct padding array to use the corrected reply size macro.
drivers/scsi/leapraid/leapraid_func.c
drivers/scsi/leapraid/leapraid_app.c
drivers/scsi/leapraid/leapraid_func.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot deepin-ci-robot requested a review from myml February 3, 2026 02:53
@opsiff opsiff changed the title scsi: leapraid: correct LEAPRAID_REPLY_SIZE macro [Deepin-Kernel-SIG] [linux 6.18.y] [Deepin] scsi: leapraid: correct LEAPRAID_REPLY_SIZE macro Feb 3, 2026
@Avenger-285714
Copy link
Member

/approve

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Avenger-285714

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a typo in the LeapRAID SCSI driver by correcting the reply buffer size macro name and updating all of its uses accordingly. This removes an inconsistent/incorrect macro identifier while preserving the existing behavior and buffer sizing.

Changes:

  • Rename LEAPRAID_REPLY_SIEZ to LEAPRAID_REPLY_SIZE in the LeapRAID header to correct the macro name.
  • Update the reply buffer struct definition to use LEAPRAID_REPLY_SIZE.
  • Update all reply-buffer-related calculations, DMA allocations/frees, address initialization, and userspace copy operations to use the corrected macro name.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
drivers/scsi/leapraid/leapraid_func.h Fixes the reply size macro name and updates the leapraid_default_reply padding array to use the corrected identifier.
drivers/scsi/leapraid/leapraid_func.c Replaces all uses of the old reply size macro in DMA size calculations, address range checks, and reply address initialization with LEAPRAID_REPLY_SIZE.
drivers/scsi/leapraid/leapraid_app.c Updates memset and min_t calls that operate on the reply buffer to use the corrected LEAPRAID_REPLY_SIZE macro.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants