feat: Sort Ahoc Sets by Benchmark Time #416
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the sorting behavior of adhoc dashboard benchmark sets to display them in chronological order based on when benchmarks were executed, rather than by set_id in descending order.
- Changed the
get_setids()function to sort by bothset_idandtimestampinstead of onlyset_idin descending order
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/resources/io/deephaven/benchmark/run/profile/queries/dashboards/adhoc_dashboard.dh.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/resources/io/deephaven/benchmark/run/profile/queries/dashboards/adhoc_dashboard.dh.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Sort adhoc dashboard benchmark sets according to when the benchmarks were run. That way they are displayed in the order the user specifies in the adhoc workflow. For all panels, we now show the sets from left to right in the order they were run. The resulting gain is more natural that way.