Skip to content

feat(vm): add target migration #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
hardcoretime wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

feat(vm): add target migration #1874

hardcoretime wants to merge 18 commits into from

Conversation

@hardcoretime
Copy link
Contributor

@hardcoretime hardcoretime commented Jan 14, 2026 •
edited
Loading

Description

A virtual machine can now be migrated to a particular node using the NodeSelector option in the virtual machine operation.

Why do we need it, and what problem does it solve?

This is required to enhance the user experience with virtual machine migration.

What is the expected result?

A virtual machine can be migrated to a particular node using defined labels.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: feature
summary: "A virtual machine can now be migrated to a particular node using the NodeSelector option in the virtual machine operation."

@hardcoretime hardcoretime added this to the v1.5.0 milestone Jan 14, 2026
@hardcoretime hardcoretime force-pushed the feat/vm/add-target-migration branch 6 times, most recently from 065512f to cca7297 Compare January 19, 2026 16:42
@hardcoretime hardcoretime marked this pull request as ready for review January 19, 2026 16:58
z9r5
z9r5 previously approved these changes Jan 20, 2026
View reviewed changes
yaroslavborbat
yaroslavborbat requested changes Jan 20, 2026
View reviewed changes
@hardcoretime hardcoretime force-pushed the feat/vm/add-target-migration branch from cca7297 to d804996 Compare January 21, 2026 00:21
yaroslavborbat
yaroslavborbat requested changes Jan 21, 2026
View reviewed changes
yaroslavborbat
yaroslavborbat previously approved these changes Jan 21, 2026
View reviewed changes
Roman Sysoev added 4 commits January 22, 2026 00:40
feat(vm): add target migration
c3cfff5 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
fix(vmop): fix CEL validation
b30fd3c 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
feat(vm): add target migration to d8 v
51f501c 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
feat(vm): add target migration e2e test
1736057 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Roman Sysoev added 9 commits January 22, 2026 00:40
feat(vm): fix linter warnings and crd descriptions
395adc4 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
feat(vm): fix linter warnings
0c9f441 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
fix crd descriptions
3140904 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
year's fix
751e213 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
improve e2e context
b698252 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
feat(vm): resolve review comments
32f230d 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
feat(vm): add force opt to target migration
3363386 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
feat(vm): resolve review comments
911400d 
- add default Alpine-BIOS virtual disk
- set the value to '20%' as the default in NewMinimalVM

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
doc(vm): add target migration
6cf3d4b 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
@hardcoretime hardcoretime force-pushed the feat/vm/add-target-migration branch 3 times, most recently from 070eb7b to 6fe45ee Compare January 21, 2026 23:15
feat(vm): add new field migrate.nodeName
1f02fd0 
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
@hardcoretime hardcoretime force-pushed the feat/vm/add-target-migration branch from 6fe45ee to 1f02fd0 Compare January 21, 2026 23:16
@hardcoretime hardcoretime marked this pull request as draft January 22, 2026 07:41
@z9r5 z9r5 requested a review from prismagod January 22, 2026 08:58
@prismagod
docs: review
d5ac59c 
Signed-off-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
prismagod
prismagod previously approved these changes Jan 22, 2026
View reviewed changes
@prismagod
docs: fix lint
971d371 
Signed-off-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
prismagod
prismagod previously approved these changes Jan 22, 2026
View reviewed changes
z9r5
z9r5 previously approved these changes Jan 22, 2026
View reviewed changes
denmaloyreb
denmaloyreb reviewed Jan 23, 2026
View reviewed changes
@prismagod @denmaloyreb
Apply suggestions from code review
7312c4f 
Co-authored-by: Denis Rebenok <60424108+denmaloyreb@users.noreply.github.com>
Signed-off-by: Vladislav Panfilov <97229646+prismagod@users.noreply.github.com>
@prismagod prismagod dismissed stale reviews from z9r5 and themself via 7312c4f January 23, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@z9r5 z9r5 z9r5 approved these changes

@denmaloyreb denmaloyreb denmaloyreb approved these changes

@prismagod prismagod prismagod approved these changes

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

@fl64 fl64 Awaiting requested review from fl64 fl64 is a code owner

@goganat goganat Awaiting requested review from goganat goganat is a code owner

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

Assignees

@hardcoretime hardcoretime

Labels

None yet

Projects

None yet

Milestone

v1.5.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hardcoretime @z9r5 @denmaloyreb @yaroslavborbat @prismagod