-
Notifications
You must be signed in to change notification settings - Fork 52
Add release workflow #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow #1254
Conversation
WalkthroughAdds a new GitHub Actions workflow to manually trigger releases with a version input; the workflow reuses an external reusable workflow and passes the version plus required secrets. A newsfragment documents the addition. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User (clicks Dispatch)
participant GH as GitHub Actions (release.yml)
participant Reuse as External Reusable Workflow
participant Secrets as Repository Secrets
User->>GH: Trigger workflow (version input)
GH->>Secrets: Read RELEASE_APP_ID, RELEASE_APP_PRIVATE_KEY
GH->>Reuse: Call reusable workflow with version + secrets
Reuse->>Secrets: Use secrets for release steps
Reuse-->>GH: Return job status
GH-->>User: Workflow completes (success/failure)
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @newsfragments/+53da9cae.misc.rst:
- Line 1: The release note text uses the lowercase "github"; update the string
"github" to the correctly capitalised proper noun "GitHub" in the new release
workflow line so it reads "releasing new versions directly from GitHub."
🧹 Nitpick comments (2)
.github/workflows/release.yml (2)
3-9: Consider adding version format validation.The
versioninput accepts any string without validation. Consider adding a pattern constraint to ensure semantic versioning format (e.g.,1.2.3) or similar convention.📝 Example with pattern validation
on: workflow_dispatch: inputs: version: description: 'New version to be added' required: true type: string + # Optionally add pattern validation for semantic versioning + # Note: GitHub Actions workflow_dispatch doesn't support pattern validation directly + # Validation would need to be in the reusable workflow or as a job stepNote: GitHub Actions
workflow_dispatchinputs don't support pattern validation directly, so validation would need to occur in the reusable workflow or as a preliminary job step.
20-21: Consider removing the trailing comment.The standalone
#comment on line 21 appears to be a formatting artifact and can be removed for cleaner formatting.🧹 Proposed cleanup
secrets: app_id: ${{ secrets.RELEASE_APP_ID }} private_key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }} - -#
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/release.ymlnewsfragments/+53da9cae.misc.rst
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: fizyk
Repo: dbfixtures/pytest-postgresql PR: 1251
File: newsfragments/+3cf1375f.docs.rst:1-7
Timestamp: 2026-01-08T13:06:06.875Z
Learning: In the pytest-postgresql repository, newsfragment filenames can use hash-based identifiers (e.g., `+3cf1375f.docs.rst`) when the work was done before an issue or PR number existed, as an acceptable alternative to the standard `[issue_number].[type].rst` format.
📚 Learning: 2026-01-08T13:06:01.573Z
Learnt from: fizyk
Repo: dbfixtures/pytest-postgresql PR: 1251
File: newsfragments/+3cf1375f.docs.rst:1-7
Timestamp: 2026-01-08T13:06:01.573Z
Learning: In the pytest-postgresql repository, allow hash-based identifiers in newsfragment filenames as an acceptable alternative to the standard [issue_number].[type].rst format when the work predates an issue or PR number. For files in the newsfragments directory, filename pattern can be +<hash>.<type>.rst (e.g., +3cf1375f.docs.rst) in addition to the usual [issue_number].[type].rst convention.
Applied to files:
newsfragments/+53da9cae.misc.rst
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: postgresql_18 / postgres (3.12)
- GitHub Check: postgresql_18 / postgres (pypy-3.11)
🔇 Additional comments (1)
.github/workflows/release.yml (1)
11-18: Verify the external workflow reference and repository secrets.The reusable workflow
fizyk/actions-reuse/.github/workflows/shared-release.yml@4.2.0could not be located through public sources. Confirm:
- The fizyk/actions-reuse repository exists and is accessible (may be private).
- Version 4.2.0 is available in that repository.
- Repository secrets
RELEASE_APP_IDandRELEASE_APP_PRIVATE_KEYare configured in GitHub repository settings.
745f5c5 to
17015da
Compare
|
@coderabbitai tbump takes care of the pattern validation. |
|
Tip For best results, initiate chat on the files or code changes. @fizyk, thank you for the clarification! I understand now that tbump handles the version pattern validation, so additional validation in the workflow isn't necessary. I've noted this for future reference. ✏️ Learnings added
🧠 Learnings used |
Chore that needs to be done:
pipenv run towncrier create [issue_number].[type].rstTypes are defined in the pyproject.toml, issue_number either from issue tracker or the Pull request number
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.