Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Dec 10, 2025

Proposed changes

we cannot rely on a 50% vertical positioning, as the height might change e.g. due to an error message. Adapting another variable by the following code:
https://github.com/db-ux-design-system/core-web/blob/5377-placeholder-for-dbselect-with-variant-floating-is-moved-down-focus-within/packages/components/src/styles/internal/_form-components.scss#L496-L498

This is mainly related to these three patterns, that could be checked on a QS of this ticket:

resolves #5377

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/5377-placeholder-for-dbselect-with-variant-floating-is-moved-down-focus-within

@mfranzke mfranzke self-assigned this Dec 10, 2025
@mfranzke mfranzke added the 🐛bug Something isn't working label Dec 10, 2025
@mfranzke mfranzke linked an issue Dec 10, 2025 that may be closed by this pull request
7 tasks
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025

🦋 Changeset detected

Latest commit: 7ac068f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@db-ux/core-components Patch
@db-ux/ngx-core-components Patch
@db-ux/react-core-components Patch
@db-ux/wc-core-components Patch
@db-ux/v-core-components Patch
@db-ux/core-foundations Patch
@db-ux/core-stylelint Patch
@db-ux/core-migration Patch
@db-ux/agent-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Dec 10, 2025
github-actions bot and others added 3 commits December 10, 2025 13:51
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
we cannot rely on a 50% positioning, as the height might change e.g. due to an error message
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the placeholder text in DBSelect components with the floating label variant was positioned incorrectly. The fix addresses vertical alignment by using a more precise calculation based on the actual sizing variable instead of a percentage.

Key Changes:

  • Updated placeholder positioning calculation in SCSS from percentage-based to variable-based
  • Added test examples for floating label variant with invalid validation state
  • Updated visual regression test snapshots to reflect the new test cases

Reviewed changes

Copilot reviewed 16 out of 26 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/components/src/styles/internal/_form-components.scss Fixed placeholder vertical positioning calculation for floating label variant
showcases/shared/select.json Added test case for floating label select with invalid validation
showcases/shared/input.json Added test case for floating label input with invalid validation
showcases/shared/custom-select.json Added test cases for floating label custom select with and without validation
Multiple snapshot files Updated aria snapshots and visual regression screenshots to include new test cases

@mfranzke mfranzke marked this pull request as ready for review December 10, 2025 14:54
@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Dec 10, 2025
github-actions bot and others added 2 commits December 10, 2025 15:16
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot and others added 2 commits December 10, 2025 18:05
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot and others added 3 commits December 10, 2025 18:35
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke enabled auto-merge (squash) December 11, 2025 02:39
@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label Dec 11, 2025
@mfranzke mfranzke requested a review from Copilot December 11, 2025 03:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 41 changed files in this pull request and generated no new comments.

@mfranzke mfranzke removed the 📕documentation Improvements or additions to documentation label Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🏘components 📺showcases Changes to 1-n showcases

Projects

Status: 🎁 Ready for review

Development

Successfully merging this pull request may close these issues.

Placeholder for DBSelect with variant floating is moved down (:focus-within)

2 participants